ziglang/zig
259
6.0k
Fork
You've already forked zig
772

spirv: use logical ops for boolean bitwise instructions #35262

Closed
quint wants to merge 1 commit from quint:spirv-fix-bool-bitwise-ops into master
pull from: quint:spirv-fix-bool-bitwise-ops
merge into: ziglang:master
ziglang:master
ziglang:elfv2
ziglang:spork8
ziglang:restricted
ziglang:0.16.x
ziglang:panic-rewrite
ziglang:parking-futex-lockfree
ziglang:windows-Io-cleanup
ziglang:Io-watch
ziglang:ParseCommandLineOptions
ziglang:windows-async-files
ziglang:poll-ring
ziglang:debug-file-leaks-differently
ziglang:debug-file-leaks
ziglang:ProcessPrng
ziglang:elfv2-dyn
ziglang:jobserver
ziglang:threadtheft
ziglang:io-threaded-no-queue
ziglang:0.15.x
ziglang:Io.net
ziglang:comptime-allocator
ziglang:restricted-function-pointers
ziglang:cli
ziglang:wasm-linker-writer
ziglang:wrangle-writer-buffering
ziglang:sha1-stream
ziglang:async-await-demo
ziglang:fixes
ziglang:0.14.x
ziglang:ast-node-methods
ziglang:macos-debug-info
ziglang:make-vs-configure
ziglang:fuzz-macos
ziglang:sans-aro
ziglang:ArrayList-reserve
ziglang:incr-bug
ziglang:llvm-ir-nosanitize-metadata
ziglang:ci-tarballs
ziglang:ci-scripts
ziglang:threadpool
ziglang:0.12.x
ziglang:new-pkg-hash
ziglang:json-diagnostics
ziglang:more-doctests
ziglang:rework-comptime-mutation
ziglang:0.11.x
ziglang:ci-perf-comment
ziglang:stage2-async
ziglang:0.10.x
ziglang:autofix
ziglang:0.9.x
ziglang:aro
ziglang:hcs
ziglang:0.8.x
ziglang:0.7.x
Contributor
Copy link

SPIR-V requires OpLogicalOr/And/NotEqual for boolean operands, but the codegen was emitting OpBitwiseOr/And/Xor unconditionally. This caused validation failures in safety checks (e.g., division overflow check computes (a != MIN) | (b != -1) on booleans).

Add airBitwiseOp() that selects the appropriate opcode based on operand type:

  • bool: OpLogicalAnd, OpLogicalOr, OpLogicalNotEqual
  • integer: OpBitwiseAnd, OpBitwiseOr, OpBitwiseXor
SPIR-V requires OpLogicalOr/And/NotEqual for boolean operands, but the codegen was emitting OpBitwiseOr/And/Xor unconditionally. This caused validation failures in safety checks (e.g., division overflow check computes `(a != MIN) | (b != -1)` on booleans). Add airBitwiseOp() that selects the appropriate opcode based on operand type: - bool: OpLogicalAnd, OpLogicalOr, OpLogicalNotEqual - integer: OpBitwiseAnd, OpBitwiseOr, OpBitwiseXor
fix(spirv): use logical ops for boolean bitwise instructions
All checks were successful
ci / x86_64-netbsd-release (pull_request) Successful in 37m3s
ci / x86_64-freebsd-release (pull_request) Successful in 37m28s
ci / x86_64-netbsd-debug (pull_request) Successful in 39m21s
ci / aarch64-macos-release (pull_request) Successful in 43m3s
ci / x86_64-linux-debug (pull_request) Successful in 44m52s
ci / x86_64-freebsd-debug (pull_request) Successful in 45m48s
ci / x86_64-windows-release (pull_request) Successful in 46m56s
ci / x86_64-openbsd-debug (pull_request) Successful in 46m58s
ci / x86_64-openbsd-release (pull_request) Successful in 47m39s
ci / aarch64-macos-debug (pull_request) Successful in 51m17s
ci / x86_64-windows-debug (pull_request) Successful in 53m29s
ci / s390x-linux-release (pull_request) Successful in 1h22m11s
ci / aarch64-linux-release (pull_request) Successful in 1h34m56s
ci / loongarch64-linux-release (pull_request) Successful in 1h45m30s
ci / powerpc64le-linux-release (pull_request) Successful in 1h54m10s
ci / aarch64-linux-debug (pull_request) Successful in 2h23m10s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h44m55s
ci / x86_64-linux-release (pull_request) Successful in 2h51m0s
ci / s390x-linux-debug (pull_request) Successful in 3h0m19s
ci / loongarch64-linux-debug (pull_request) Successful in 3h0m11s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h20m23s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Successful in 2h38m40s
ci / aarch64-freebsd-debug (pull_request) Successful in 3h58m11s
ci / aarch64-netbsd-debug (pull_request) Successful in 4h20m10s
ci / aarch64-netbsd-release (pull_request) Successful in 3h11m12s
917e0b9ddc 
SPIR-V requires OpLogicalOr/And/NotEqual for boolean operands, but
the codegen was emitting OpBitwiseOr/And/Xor unconditionally. This
caused validation failures in safety checks (e.g., division overflow
check computes `(a != MIN) | (b != -1)` on booleans).
Add airBitwiseOp() that selects the appropriate opcode based on
operand type:
- bool: OpLogicalAnd, OpLogicalOr, OpLogicalNotEqual
- integer: OpBitwiseAnd, OpBitwiseOr, OpBitwiseXor
quint changed title from (削除) fix(spirv): use logical ops for boolean bitwise instructions (削除ここまで) to spirv: use logical ops for boolean bitwise instructions 2026年05月09日 19:29:39 +02:00
@ -0,0 +1,50 @@
// Test that boolean bitwise operations use logical opcodes in SPIR-V

This test is redundant. Instead we should enable the corresponding behavior tests and in future, maybe run spirv-validator on the output?

This test is redundant. Instead we should enable the corresponding behavior tests and in future, maybe run spirv-validator on the output?

Thank You!
Co-Authored in #35777

Thank You! Co-Authored in #35777
All checks were successful
ci / x86_64-netbsd-release (pull_request) Successful in 37m3s
Required
Details
ci / x86_64-freebsd-release (pull_request) Successful in 37m28s
Required
Details
ci / x86_64-netbsd-debug (pull_request) Successful in 39m21s
Required
Details
ci / aarch64-macos-release (pull_request) Successful in 43m3s
Required
Details
ci / x86_64-linux-debug (pull_request) Successful in 44m52s
Required
Details
ci / x86_64-freebsd-debug (pull_request) Successful in 45m48s
Required
Details
ci / x86_64-windows-release (pull_request) Successful in 46m56s
Required
Details
ci / x86_64-openbsd-debug (pull_request) Successful in 46m58s
Required
Details
ci / x86_64-openbsd-release (pull_request) Successful in 47m39s
Required
Details
ci / aarch64-macos-debug (pull_request) Successful in 51m17s
Required
Details
ci / x86_64-windows-debug (pull_request) Successful in 53m29s
Required
Details
ci / s390x-linux-release (pull_request) Successful in 1h22m11s
Required
Details
ci / aarch64-linux-release (pull_request) Successful in 1h34m56s
Required
Details
ci / loongarch64-linux-release (pull_request) Successful in 1h45m30s
ci / powerpc64le-linux-release (pull_request) Successful in 1h54m10s
Required
Details
ci / aarch64-linux-debug (pull_request) Successful in 2h23m10s
Required
Details
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h44m55s
Required
Details
ci / x86_64-linux-release (pull_request) Successful in 2h51m0s
Required
Details
ci / s390x-linux-debug (pull_request) Successful in 3h0m19s
Required
Details
ci / loongarch64-linux-debug (pull_request) Successful in 3h0m11s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h20m23s
Required
Details
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-freebsd-release (pull_request) Successful in 2h38m40s
ci / aarch64-freebsd-debug (pull_request) Successful in 3h58m11s
ci / aarch64-netbsd-debug (pull_request) Successful in 4h20m10s
ci / aarch64-netbsd-release (pull_request) Successful in 3h11m12s

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!35262
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "quint:spirv-fix-bool-bitwise-ops"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?