ziglang/zig
259
6.0k
Fork
You've already forked zig
770

std: fix: add Io interface parameter to getUserInfo() (#35214) #35217

Open
tkatter wants to merge 2 commits from tkatter/zig:issue-35214 into master
pull from: tkatter/zig:issue-35214
merge into: ziglang:master
ziglang:master
ziglang:elfv2
ziglang:spork8
ziglang:restricted
ziglang:0.16.x
ziglang:panic-rewrite
ziglang:parking-futex-lockfree
ziglang:windows-Io-cleanup
ziglang:Io-watch
ziglang:ParseCommandLineOptions
ziglang:windows-async-files
ziglang:poll-ring
ziglang:debug-file-leaks-differently
ziglang:debug-file-leaks
ziglang:ProcessPrng
ziglang:elfv2-dyn
ziglang:jobserver
ziglang:threadtheft
ziglang:io-threaded-no-queue
ziglang:0.15.x
ziglang:Io.net
ziglang:comptime-allocator
ziglang:restricted-function-pointers
ziglang:cli
ziglang:wasm-linker-writer
ziglang:wrangle-writer-buffering
ziglang:sha1-stream
ziglang:async-await-demo
ziglang:fixes
ziglang:0.14.x
ziglang:ast-node-methods
ziglang:macos-debug-info
ziglang:make-vs-configure
ziglang:fuzz-macos
ziglang:sans-aro
ziglang:ArrayList-reserve
ziglang:incr-bug
ziglang:llvm-ir-nosanitize-metadata
ziglang:ci-tarballs
ziglang:ci-scripts
ziglang:threadpool
ziglang:0.12.x
ziglang:new-pkg-hash
ziglang:json-diagnostics
ziglang:more-doctests
ziglang:rework-comptime-mutation
ziglang:0.11.x
ziglang:ci-perf-comment
ziglang:stage2-async
ziglang:0.10.x
ziglang:autofix
ziglang:0.9.x
ziglang:aro
ziglang:hcs
ziglang:0.8.x
ziglang:0.7.x
First-time contributor
Copy link

This fixes #35214. The public API exposed by std.process.getUserInfo() was missing the Io interface parameter to be propagated down to the underlying std.process.posixGetUserInfo() call.

The std.process.posixGetUserInfo() also had a bug where it was not passing the Io interface to file.reader(), this fixed that aswell.

Note: This is a draft PR for one reason, I have not built and tested with the changes, though trivial.

Would anyone be able to point me in the direction for running the build steps? I tried following the README.md, created build, ran cmake and ran into issues with it not finding zstd library (which I had). Would the correct steps be to first build zig like I attempted, then I would have the stage3 directory for which I could build stage4 and then run stage4/bin/zig build test-std -Dskip-release?

This fixes [#35214](https://codeberg.org/ziglang/zig/issues/35214#issue-4879925). The public API exposed by `std.process.getUserInfo()` was missing the `Io` interface parameter to be propagated down to the underlying `std.process.posixGetUserInfo()` call. The `std.process.posixGetUserInfo()` also had a bug where it was not passing the `Io` interface to `file.reader()`, this fixed that aswell. --- **Note**: This is a draft PR for one reason, I have not built and tested with the changes, though trivial. Would anyone be able to point me in the direction for running the build steps? I tried following the `README.md`, created `build`, ran `cmake` and ran into issues with it not finding `zstd` library (which I had). Would the correct steps be to first build zig like I attempted, then I would have the `stage3` directory for which I could build stage4 and then run `stage4/bin/zig build test-std -Dskip-release`?
fix: add Io interface parameter to getUserInfo()
Some checks are pending
ci / aarch64-freebsd-debug (pull_request) Blocked by required conditions
ci / aarch64-freebsd-release (pull_request) Blocked by required conditions
ci / aarch64-linux-debug (pull_request) Blocked by required conditions
ci / aarch64-linux-release (pull_request) Blocked by required conditions
ci / aarch64-netbsd-debug (pull_request) Blocked by required conditions
ci / aarch64-netbsd-release (pull_request) Blocked by required conditions
ci / aarch64-macos-debug (pull_request) Blocked by required conditions
ci / aarch64-macos-release (pull_request) Blocked by required conditions
ci / loongarch64-linux-debug (pull_request) Blocked by required conditions
ci / loongarch64-linux-release (pull_request) Blocked by required conditions
ci / powerpc64le-linux-debug (pull_request) Blocked by required conditions
ci / powerpc64le-linux-release (pull_request) Blocked by required conditions
ci / riscv64-linux-debug (pull_request) Blocked by required conditions
ci / riscv64-linux-release (pull_request) Blocked by required conditions
ci / s390x-linux-debug (pull_request) Blocked by required conditions
ci / s390x-linux-release (pull_request) Blocked by required conditions
ci / x86_64-freebsd-debug (pull_request) Blocked by required conditions
ci / x86_64-freebsd-release (pull_request) Blocked by required conditions
ci / x86_64-linux-debug (pull_request) Blocked by required conditions
ci / x86_64-linux-debug-llvm (pull_request) Blocked by required conditions
ci / x86_64-linux-release (pull_request) Blocked by required conditions
ci / x86_64-netbsd-debug (pull_request) Blocked by required conditions
ci / x86_64-netbsd-release (pull_request) Blocked by required conditions
ci / x86_64-openbsd-debug (pull_request) Blocked by required conditions
ci / x86_64-openbsd-release (pull_request) Blocked by required conditions
ci / x86_64-windows-debug (pull_request) Blocked by required conditions
ci / x86_64-windows-release (pull_request) Blocked by required conditions
5d5703f88a
First-time contributor
Copy link

I have not built and tested with the changes, though trivial.

@tkatter Maybe I'm misreading this, but you can test the code for your example program without re-/building zig itself (in case you didn't know):

.
The standard library is always built from its source in the lib directory next to your zig exe / installation. Since this change is entirely within std, if you change the source in lib/std/process.zig that should be picked up the next time you compile the example program, so you can test whether the fix works for your use case.

Two things this wouldn't cover though:
(1) usages within the compiler's code base itself (if it uses that function - requires building the compiler afaik).
(2) test cases within std (should also be testable without re-/building zig, though I'm not sure what the right command/invocation is).

> I have not built and tested with the changes, though trivial. <details> <summary> @tkatter Maybe I'm misreading this, but you can test the code for your example program without re-/building zig itself (in case you didn't know): </summary> . The standard library is always built from its source in the `lib` directory next to your zig exe / installation. Since this change is entirely within `std`, if you change the source in `lib/std/process.zig` that should be picked up the next time you compile the example program, so you can test whether the fix works for your use case. Two things this wouldn't cover though: (1) usages within the compiler's code base itself (if it uses that function - requires building the compiler afaik). (2) test cases within `std` (should also be testable without re-/building zig, though I'm not sure what the right command/invocation is). </details>
Author
First-time contributor
Copy link

you can test the code for your example program without re-/building zig itself

Yeah thanks. I figured this out, and my changes applied here caused no problems, fixing the issue I initially stumbled across.

@rohlem From what I understand between your comment and the README.md, cloning the zig repo and building it is more or less just building the zig compiler and other internals - not the stdlib since that is built alongside any zig program when running zig build. Therefore, for a change like mine here in this PR, building the zig repo is probably unnecessary (I will still do it to make sure ;) ) since the changes are just in std. The README.md mentions running std tests, like you've also mentioned, I will look into how I can run those.

This seem like an accurate understanding? Thanks for the help!

> you can test the code for your example program without re-/building zig itself Yeah thanks. I figured this out, and my changes applied here caused no problems, fixing the issue I initially stumbled across. @rohlem From what I understand between your comment and the `README.md`, cloning the zig repo and building it is more or less just building the zig compiler and other internals - _not the stdlib_ since that is built alongside any zig program when running `zig build`. Therefore, for a change like mine here in this PR, building the zig repo is _probably_ unnecessary (I will still do it to make sure ;) ) since the changes are just in std. The `README.md` mentions running std tests, like you've also mentioned, I will look into how I can run those. This seem like an accurate understanding? Thanks for the help!
Merge branch 'master' into issue-35214
All checks were successful
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Successful in 54m40s
ci / aarch64-macos-debug (pull_request) Successful in 1h5m23s
ci / aarch64-linux-release (pull_request) Successful in 1h37m18s
ci / x86_64-netbsd-debug (pull_request) Successful in 42m33s
ci / x86_64-linux-debug (pull_request) Successful in 1h39m40s
ci / x86_64-netbsd-release (pull_request) Successful in 40m53s
ci / x86_64-freebsd-debug (pull_request) Successful in 43m45s
ci / x86_64-freebsd-release (pull_request) Successful in 43m28s
ci / s390x-linux-release (pull_request) Successful in 1h52m15s
ci / x86_64-linux-release (pull_request) Successful in 1h53m7s
ci / x86_64-openbsd-release (pull_request) Successful in 47m32s
ci / x86_64-windows-release (pull_request) Successful in 49m20s
ci / x86_64-openbsd-debug (pull_request) Successful in 53m17s
ci / x86_64-windows-debug (pull_request) Successful in 53m5s
ci / powerpc64le-linux-release (pull_request) Successful in 2h19m59s
ci / aarch64-linux-debug (pull_request) Successful in 2h33m1s
ci / s390x-linux-debug (pull_request) Successful in 2h41m10s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h53m29s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h31m9s
ci / loongarch64-linux-release (pull_request) Successful in 2h1m57s
ci / loongarch64-linux-debug (pull_request) Successful in 3h30m18s
ci / aarch64-freebsd-debug (pull_request) Successful in 3h38m44s
ci / aarch64-freebsd-release (pull_request) Successful in 2h58m26s
ci / aarch64-netbsd-debug (pull_request) Successful in 4h14m42s
ci / aarch64-netbsd-release (pull_request) Successful in 3h36m10s
da3f9b9048
Author
First-time contributor
Copy link

Okay, sorry about the delay, nuked my system on accident after deleting a bunch of old llvm installs so just started fresh with a new install of arch XD. Anyways, I've ran the following tests and all of them finished without any complaints:

zig build test-std
zig build test-std -Dskip-release
zig test lib/std/std.zig --zig-lib-dir lib

So I'm removing the WIP prefix as it seems to all checkout. Sorry about the merge from master into the PR branch, mean to rebase but thought Codeberg was telling me the PR branch is out of date with my fork's branch, not the master, which I wanted to rebase onto...

Okay, sorry about the delay, nuked my system on accident after deleting a bunch of old llvm installs so just started fresh with a new install of arch XD. Anyways, I've ran the following tests and all of them finished without any complaints: ```sh zig build test-std zig build test-std -Dskip-release zig test lib/std/std.zig --zig-lib-dir lib ``` So I'm removing the `WIP` prefix as it seems to all checkout. Sorry about the merge from `master` into the PR branch, mean to rebase but thought Codeberg was telling me the PR branch is out of date with my fork's branch, not the master, which I wanted to rebase onto...
tkatter changed title from (削除) WIP: std: fix: add Io interface parameter to getUserInfo() (#35214) (削除ここまで) to std: fix: add Io interface parameter to getUserInfo() (#35214) 2026年05月12日 18:40:35 +02:00
All checks were successful
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / aarch64-macos-release (pull_request) Successful in 54m40s
Required
Details
ci / aarch64-macos-debug (pull_request) Successful in 1h5m23s
Required
Details
ci / aarch64-linux-release (pull_request) Successful in 1h37m18s
Required
Details
ci / x86_64-netbsd-debug (pull_request) Successful in 42m33s
Required
Details
ci / x86_64-linux-debug (pull_request) Successful in 1h39m40s
Required
Details
ci / x86_64-netbsd-release (pull_request) Successful in 40m53s
Required
Details
ci / x86_64-freebsd-debug (pull_request) Successful in 43m45s
Required
Details
ci / x86_64-freebsd-release (pull_request) Successful in 43m28s
Required
Details
ci / s390x-linux-release (pull_request) Successful in 1h52m15s
Required
Details
ci / x86_64-linux-release (pull_request) Successful in 1h53m7s
Required
Details
ci / x86_64-openbsd-release (pull_request) Successful in 47m32s
Required
Details
ci / x86_64-windows-release (pull_request) Successful in 49m20s
Required
Details
ci / x86_64-openbsd-debug (pull_request) Successful in 53m17s
Required
Details
ci / x86_64-windows-debug (pull_request) Successful in 53m5s
Required
Details
ci / powerpc64le-linux-release (pull_request) Successful in 2h19m59s
Required
Details
ci / aarch64-linux-debug (pull_request) Successful in 2h33m1s
Required
Details
ci / s390x-linux-debug (pull_request) Successful in 2h41m10s
Required
Details
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h53m29s
Required
Details
ci / powerpc64le-linux-debug (pull_request) Successful in 3h31m9s
Required
Details
ci / loongarch64-linux-release (pull_request) Successful in 2h1m57s
ci / loongarch64-linux-debug (pull_request) Successful in 3h30m18s
ci / aarch64-freebsd-debug (pull_request) Successful in 3h38m44s
ci / aarch64-freebsd-release (pull_request) Successful in 2h58m26s
ci / aarch64-netbsd-debug (pull_request) Successful in 4h14m42s
ci / aarch64-netbsd-release (pull_request) Successful in 3h36m10s
This pull request can be merged automatically.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u issue-35214:tkatter-issue-35214
git switch tkatter-issue-35214
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!35217
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "tkatter/zig:issue-35214"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?