ziglang/zig
259
6.0k
Fork
You've already forked zig
772

Fetch: Fix zip fetching when cache directory doesn't have tmp dir #31965

Merged
andrewrk merged 1 commit from squeek502/zig:fetch-zip-empty-cache into master 2026年04月21日 18:07:44 +02:00

Fixes #31964

Fixes #31964
andrewrk requested changes 2026年04月20日 18:31:59 +02:00
Dismissed
andrewrk left a comment
Copy link

Thanks for the fix. Can you please put this in the while loop in response to the error.FileNotFound? This will avoid the mkdir syscall in the hot path.

Thanks for the fix. Can you please put this in the while loop in response to the `error.FileNotFound`? This will avoid the mkdir syscall in the hot path.
@ -1486,1 +1486,4 @@
cache_root.handle.createDir(io,prefix,.default_dir)catch|err|switch(err){
error.PathAlreadyExists=>{},
error.Canceled=>returnerror.Canceled,
Owner
Copy link

this idiom avoids footgun of typo in inferred error set functions
error.Canceled => |e| return e,

this idiom avoids footgun of typo in inferred error set functions `error.Canceled => |e| return e,`
Author
Owner
Copy link

There's actually quite a few places that don't follow this idiom. Will correct it locally in this PR and submit a separate PR for the rest.

There's actually quite a few places that don't follow this idiom. Will correct it locally in this PR and submit a separate PR for the rest.
squeek502 marked this conversation as resolved
squeek502 force-pushed fetch-zip-empty-cache from c29506667b
Some checks are pending
ci / aarch64-freebsd-debug (pull_request) Waiting to run
ci / aarch64-freebsd-release (pull_request) Waiting to run
ci / aarch64-netbsd-debug (pull_request) Waiting to run
ci / aarch64-netbsd-release (pull_request) Waiting to run
ci / riscv64-linux-debug (pull_request) Waiting to run
ci / riscv64-linux-release (pull_request) Waiting to run
ci / x86_64-freebsd-release (pull_request) Successful in 55m3s
ci / x86_64-netbsd-release (pull_request) Successful in 55m38s
ci / x86_64-linux-debug (pull_request) Successful in 59m38s
ci / aarch64-macos-release (pull_request) Successful in 1h1m1s
ci / x86_64-netbsd-debug (pull_request) Successful in 1h5m39s
ci / x86_64-freebsd-debug (pull_request) Successful in 1h5m55s
ci / x86_64-openbsd-release (pull_request) Successful in 1h19m40s
ci / aarch64-macos-debug (pull_request) Successful in 1h20m43s
ci / x86_64-windows-release (pull_request) Successful in 1h20m12s
ci / s390x-linux-release (pull_request) Successful in 1h25m17s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h29m13s
ci / aarch64-linux-release (pull_request) Successful in 1h36m44s
ci / powerpc64le-linux-release (pull_request) Successful in 1h40m19s
ci / x86_64-windows-debug (pull_request) Successful in 1h59m54s
ci / aarch64-linux-debug (pull_request) Successful in 2h24m8s
ci / s390x-linux-debug (pull_request) Successful in 2h28m47s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 2h42m39s
ci / powerpc64le-linux-debug (pull_request) Successful in 3h20m25s
ci / x86_64-linux-release (pull_request) Successful in 3h29m50s
ci / loongarch64-linux-release (pull_request) Successful in 2h1m27s
ci / loongarch64-linux-debug (pull_request) Successful in 3h22m13s
to b57ab4fb23
Some checks failed
ci / loongarch64-linux-debug (pull_request) Waiting to run
ci / loongarch64-linux-release (pull_request) Waiting to run
ci / riscv64-linux-debug (pull_request) Waiting to run
ci / riscv64-linux-release (pull_request) Waiting to run
ci / x86_64-netbsd-release (pull_request) Successful in 51m6s
ci / x86_64-freebsd-release (pull_request) Successful in 50m6s
ci / aarch64-macos-release (pull_request) Successful in 1h47m3s
ci / x86_64-netbsd-debug (pull_request) Successful in 57m51s
ci / x86_64-freebsd-debug (pull_request) Successful in 1h0m26s
ci / aarch64-macos-debug (pull_request) Successful in 2h8m33s
ci / powerpc64le-linux-release (pull_request) Successful in 1h28m40s
ci / aarch64-linux-release (pull_request) Successful in 1h24m21s
ci / aarch64-linux-debug (pull_request) Successful in 2h44m51s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h27m15s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h16m59s
ci / x86_64-openbsd-release (pull_request) Successful in 54m18s
ci / x86_64-windows-release (pull_request) Successful in 1h15m1s
ci / x86_64-windows-debug (pull_request) Successful in 1h42m3s
ci / x86_64-linux-debug (pull_request) Successful in 1h19m4s
ci / x86_64-linux-release (pull_request) Successful in 3h9m48s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h28m32s
ci / s390x-linux-release (pull_request) Successful in 1h48m57s
ci / s390x-linux-debug (pull_request) Successful in 3h5m22s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
2026年04月21日 01:34:02 +02:00 Compare
andrewrk scheduled this pull request to auto merge when all checks succeed 2026年04月21日 06:50:51 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!31965
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "squeek502/zig:fetch-zip-empty-cache"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?