ziglang/zig
261
6.0k
Fork
You've already forked zig
776

libzigc: move all unit tests from lib/c/ to test/c/ #31923

Merged
alexrp merged 4 commits from alexrp/zig:libc-test-refactor into master 2026年04月17日 22:31:38 +02:00

Before:

  • test-zigc: run libzigc unit tests (part of test-modules)
  • test-libc: run libc-test cases

Now:

  • test-libc: run libc API unit tests (part of test-modules)
  • test-libc-nsz: run libc-test cases

libc API unit tests (previously referred to as libzigc unit tests) now run for all supported targets, even those we don't provide libzigc for. The idea is that this will help us catch bad assumptions in the unit tests, as well as bugs in other libcs.

I considered this setup:

  • test-c: run libc API unit tests (part of test-modules)
  • test-libc-nsz: run libc-test cases
  • test-libc: both of the above

However, I do not like it because it gives a false sense of security; the full module and C ABI test suites are still liable to catch libzigc bugs that test-c and test-libc-nsz might not. So contributors should just run the test steps outlined in #30978 (which will be updated after this PR is merged).

Before: * `test-zigc`: run libzigc unit tests (part of `test-modules`) * `test-libc`: run libc-test cases Now: * `test-libc`: run libc API unit tests (part of `test-modules`) * `test-libc-nsz`: run libc-test cases libc API unit tests (previously referred to as libzigc unit tests) now run for all supported targets, even those we don't provide libzigc for. The idea is that this will help us catch bad assumptions in the unit tests, as well as bugs in other libcs. I considered this setup: * `test-c`: run libc API unit tests (part of `test-modules`) * `test-libc-nsz`: run libc-test cases * `test-libc`: both of the above However, I do not like it because it gives a false sense of security; the full module and C ABI test suites are still liable to catch libzigc bugs that `test-c` and `test-libc-nsz` might not. So contributors should just run the test steps outlined in #30978 (which will be updated after this PR is merged).
This is distinct from the question of whether the target formally considers libc
to be the only stable syscall interface; for example, FreeBSD and NetBSD have
stable syscalls, but we don't yet have syscall layers for them in std.os.
For a test target with link_libc = null, we need to skip it if we would
implicitly link libc because the target requires it or because we don't yet have
a syscall layer for it.
Before:
* test-zigc: run libzigc unit tests (part of test-modules)
* test-libc: run libc-test cases
Now:
* test-libc: run libc API unit tests (part of test-modules)
* test-libc-nsz: run libc-test cases
libc API unit tests (previously referred to as libzigc unit tests) now run for
all supported targets, even those we don't provide libzigc for. The idea is that
this will help us catch bad assumptions in the unit tests, as well as bugs in
other libcs.
I considered this setup:
* test-c: run libc API unit tests (part of test-modules)
* test-libc-nsz: run libc-test cases
* test-libc: both of the above
However, I do not like it because it gives a false sense of security; the full
module and C ABI test suites are still liable to catch libzigc bugs that test-c
and test-libc-nsz might not. So contributors should just run the test steps
outlined in #30978.
Co-authored-by: rpkak <rpkak@noreply.codeberg.org>
Author
Owner
Copy link

Note: Please don't merge this PR until it has run through all jobs, since the new test-libc has a high likelihood of introducing platform-specific test failures.

Note: Please don't merge this PR until it has run through all jobs, since the new `test-libc` has a high likelihood of introducing platform-specific test failures.
alexrp force-pushed libc-test-refactor from 75488134ae
Some checks failed
ci / x86_64-freebsd-release (pull_request) Successful in 46m28s
ci / x86_64-netbsd-debug (pull_request) Failing after 47m35s
ci / aarch64-macos-debug (pull_request) Successful in 2h3m25s
ci / x86_64-freebsd-debug (pull_request) Successful in 58m40s
ci / x86_64-linux-debug (pull_request) Successful in 1h18m11s
ci / aarch64-macos-release (pull_request) Successful in 1h57m11s
ci / x86_64-openbsd-release (pull_request) Failing after 54m47s
ci / aarch64-linux-release (pull_request) Has been cancelled
ci / aarch64-linux-debug (pull_request) Has been cancelled
ci / s390x-linux-debug (pull_request) Has been cancelled
ci / x86_64-openbsd-debug (pull_request) Has been cancelled
ci / x86_64-netbsd-release (pull_request) Has been cancelled
ci / x86_64-linux-debug-llvm (pull_request) Has been cancelled
ci / x86_64-linux-release (pull_request) Has been cancelled
ci / x86_64-windows-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
ci / s390x-linux-release (pull_request) Has been cancelled
ci / x86_64-windows-release (pull_request) Has been cancelled
to 6612e7cdb2
Some checks failed
ci / x86_64-freebsd-release (pull_request) Successful in 49m34s
ci / x86_64-netbsd-debug (pull_request) Successful in 53m52s
ci / x86_64-netbsd-release (pull_request) Successful in 44m13s
ci / x86_64-freebsd-debug (pull_request) Successful in 1h6m54s
ci / aarch64-linux-release (pull_request) Successful in 1h30m52s
ci / aarch64-macos-release (pull_request) Successful in 1h51m12s
ci / x86_64-linux-debug (pull_request) Successful in 1h36m23s
ci / aarch64-macos-debug (pull_request) Successful in 2h2m44s
ci / aarch64-linux-debug (pull_request) Successful in 2h26m35s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h21m56s
ci / x86_64-openbsd-release (pull_request) Successful in 1h10m58s
ci / x86_64-linux-release (pull_request) Successful in 2h52m7s
ci / s390x-linux-release (pull_request) Successful in 1h36m31s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h42m34s
ci / x86_64-windows-debug (pull_request) Successful in 1h35m47s
ci / s390x-linux-debug (pull_request) Successful in 3h21m50s
ci / x86_64-windows-release (pull_request) Successful in 1h27m49s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / powerpc64le-linux-debug (pull_request) Has been cancelled
ci / powerpc64le-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
2026年04月17日 15:13:26 +02:00 Compare
andrewrk left a comment
Copy link

Beautiful

Beautiful

Note: Please don't merge this PR until it has run through all jobs, since the new test-libc has a high likelihood of introducing platform-specific test failures.

Do as you please, but since master is failing CI and this will fix it, might as well merge it right? The failures on the lower tier targets can be addressed as the master branch CI runs complete.

> Note: Please don't merge this PR until it has run through all jobs, since the new `test-libc` has a high likelihood of introducing platform-specific test failures. Do as you please, but since master is failing CI and this will fix it, might as well merge it right? The failures on the lower tier targets can be addressed as the master branch CI runs complete.
Author
Owner
Copy link

Sure, I mainly just wanted a run on every OS before merging. I don't expect LoongArch and PowerPC to fail since they didn't under QEMU.

Sure, I mainly just wanted a run on every OS before merging. I don't expect LoongArch and PowerPC to fail since they didn't under QEMU.
alexrp deleted branch libc-test-refactor 2026年04月17日 22:31:40 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!31923
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "alexrp/zig:libc-test-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?