ziglang/zig
147
2.9k
Fork
You've already forked zig
271

feat: init eZ80 arch via CBE #30622

Open
clevor wants to merge 1 commit from clevor/zig:ez80 into master
pull from: clevor/zig:ez80
merge into: ziglang:master
ziglang:master
ziglang:one-mutex-per-mutex
ziglang:mmap
ziglang:riscv-ci
ziglang:test-no-bin
ziglang:poll
ziglang:io-uring-update
ziglang:llvm22
ziglang:poll-ring
ziglang:debug-file-leaks-differently
ziglang:debug-file-leaks
ziglang:hate-letter-to-std.os
ziglang:i-am-a-foolish-fool
ziglang:ProcessPrng
ziglang:elfv2-dyn
ziglang:jobserver
ziglang:threadtheft
ziglang:io-threaded-no-queue
ziglang:0.15.x
ziglang:Io.net
ziglang:comptime-allocator
ziglang:restricted-function-pointers
ziglang:cli
ziglang:wasm-linker-writer
ziglang:wrangle-writer-buffering
ziglang:sha1-stream
ziglang:async-await-demo
ziglang:fixes
ziglang:0.14.x
ziglang:ast-node-methods
ziglang:spork8
ziglang:macos-debug-info
ziglang:make-vs-configure
ziglang:fuzz-macos
ziglang:main
ziglang:sans-aro
ziglang:ArrayList-reserve
ziglang:incr-bug
ziglang:llvm-ir-nosanitize-metadata
ziglang:ci-tarballs
ziglang:ci-scripts
ziglang:threadpool
ziglang:0.12.x
ziglang:new-pkg-hash
ziglang:json-diagnostics
ziglang:more-doctests
ziglang:rework-comptime-mutation
ziglang:0.11.x
ziglang:ci-perf-comment
ziglang:stage2-async
ziglang:0.10.x
ziglang:autofix
ziglang:0.9.x
ziglang:aro
ziglang:hcs
ziglang:0.8.x
ziglang:0.7.x
First-time contributor
Copy link

Continuation of #25680, squished into one commit for now

Continuation of #25680, squished into one commit for now
feat: init eZ80 arch via CBE
All checks were successful
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / x86_64-windows-release (pull_request) Successful in 53m58s
ci / x86_64-windows-debug (pull_request) Successful in 54m56s
ci / x86_64-freebsd-release (pull_request) Successful in 1h10m23s
ci / x86_64-linux-debug (pull_request) Successful in 1h17m50s
ci / x86_64-freebsd-debug (pull_request) Successful in 1h18m28s
ci / aarch64-macos-release (pull_request) Successful in 1h22m35s
ci / s390x-linux-release (pull_request) Successful in 1h31m1s
ci / aarch64-linux-release (pull_request) Successful in 1h41m36s
ci / aarch64-macos-debug (pull_request) Successful in 2h22m18s
ci / aarch64-linux-debug (pull_request) Successful in 2h28m30s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h7m25s
ci / s390x-linux-debug (pull_request) Successful in 3h30m52s
ci / x86_64-linux-release (pull_request) Successful in 3h31m40s
ci / loongarch64-linux-debug (pull_request) Successful in 3h30m10s
ci / loongarch64-linux-release (pull_request) Successful in 2h9m25s
0f5bdf7f96
andrewrk left a comment
Owner
Copy link

Thanks for the patch.

I've never messed with ez80 or z80 before, so I may be mistaken here, but I've done my best to review this in the interest of getting it landed.

Everywhere that #if defined(zig_ez80) appears in zig.h, it looks wrong to me. I also challenged the decision to use "ez80" as the arch rather than "z80". Other than that, I think this looks ready to land.

Thanks for the patch. I've never messed with ez80 or z80 before, so I may be mistaken here, but I've done my best to review this in the interest of getting it landed. Everywhere that `#if defined(zig_ez80)` appears in zig.h, it looks wrong to me. I also challenged the decision to use "ez80" as the arch rather than "z80". Other than that, I think this looks ready to land.
@ -1312,6 +1326,7 @@ pub const Cpu = struct {
bpfeb,
bpfel,
csky,
ez80,
Owner
Copy link

It looks like this should be z80, maybe with a target CPU feature of "e", although if that is only changing the clock frequency it's unclear that there is a meaningful difference between ez80 and z80 from a compiler's perspective.

It looks like this should be z80, maybe with a target CPU feature of "e", although if that is only changing the clock frequency it's unclear that there is a meaningful difference between ez80 and z80 from a compiler's perspective.
First-time contributor
Copy link

@andrewrk wrote in #30622 (comment):

It looks like this should be z80, maybe with a target CPU feature of "e", although if that is only changing the clock frequency it's unclear that there is a meaningful difference between ez80 and z80 from a compiler's perspective.

While it's quite similar, it's actually got some architectural improvements (simple pipeline, new instructions...) and famously has a full 24-bit address mode ("ADL") and indeed can be clocked faster.

@andrewrk wrote in https://codeberg.org/ziglang/zig/pulls/30622#issuecomment-9354818: > It looks like this should be z80, maybe with a target CPU feature of "e", although if that is only changing the clock frequency it's unclear that there is a meaningful difference between ez80 and z80 from a compiler's perspective. While it's quite similar, it's actually got some architectural improvements (simple pipeline, new instructions...) and famously has a full 24-bit address mode ("ADL") and indeed can be clocked faster.
lib/zig.h Outdated
@ -80,2 +80,4 @@
#define zig_x86_16
#define zig_x86
#elif defined (__ez80)
#define zig_ez80
Owner
Copy link

what is the purpose of defining zig_ez80?

what is the purpose of defining `zig_ez80`?
lib/zig.h Outdated
@ -582,6 +587,16 @@ typedef signed long long int16_t;
#define INT16_MAX ( INT16_C(0x7FFF))
#define UINT16_MAX ( INT16_C(0xFFFF))
#if defined(zig_ez80)
Owner
Copy link

It looks wrong to check the OS rather than checking the min and max like all the rest of the surrounding macros.

It looks wrong to check the OS rather than checking the min and max like all the rest of the surrounding macros.
@ -707,6 +737,12 @@ const Index = enum(u32) {
zig_f128,
zig_c_longdouble,
//ez80stdint.h
Owner
Copy link

these are unrelated to ez80. they are defined in stdint.h just like the others

these are unrelated to ez80. they are defined in stdint.h just like the others
Author
First-time contributor
Copy link

The width of an eZ80 register pair, at least in ADL mode, is 24 bits, and the CE toolchain's fork of jacobly's fork also supports 48-bit integers implemented as 2 24-bit register pairs.

The width of an eZ80 register pair, at least in ADL mode, is 24 bits, and the [CE toolchain's fork](https://github.com/CE-Programming/llvm-project) of [jacobly's fork](https://github.com/jacobly0/llvm-project) also supports 48-bit integers implemented as 2 24-bit register pairs.

FWIW, I have some comments to add to the discussion here, but won't have time until I'm back home on the 3rd.

FWIW, I have some comments to add to the discussion here, but won't have time until I'm back home on the 3rd.
clevor force-pushed ez80 from 0f5bdf7f96
All checks were successful
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / x86_64-windows-release (pull_request) Successful in 53m58s
ci / x86_64-windows-debug (pull_request) Successful in 54m56s
ci / x86_64-freebsd-release (pull_request) Successful in 1h10m23s
ci / x86_64-linux-debug (pull_request) Successful in 1h17m50s
ci / x86_64-freebsd-debug (pull_request) Successful in 1h18m28s
ci / aarch64-macos-release (pull_request) Successful in 1h22m35s
ci / s390x-linux-release (pull_request) Successful in 1h31m1s
ci / aarch64-linux-release (pull_request) Successful in 1h41m36s
ci / aarch64-macos-debug (pull_request) Successful in 2h22m18s
ci / aarch64-linux-debug (pull_request) Successful in 2h28m30s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 3h7m25s
ci / s390x-linux-debug (pull_request) Successful in 3h30m52s
ci / x86_64-linux-release (pull_request) Successful in 3h31m40s
ci / loongarch64-linux-debug (pull_request) Successful in 3h30m10s
ci / loongarch64-linux-release (pull_request) Successful in 2h9m25s
to 257cbfbb7c
All checks were successful
ci / aarch64-macos-release (pull_request) Successful in 27m56s
ci / x86_64-freebsd-release (pull_request) Successful in 34m53s
ci / x86_64-windows-debug (pull_request) Successful in 41m10s
ci / x86_64-windows-release (pull_request) Successful in 44m1s
ci / x86_64-freebsd-debug (pull_request) Successful in 46m31s
ci / x86_64-openbsd-release (pull_request) Successful in 48m48s
ci / x86_64-openbsd-debug (pull_request) Successful in 56m9s
ci / aarch64-macos-debug (pull_request) Successful in 1h0m29s
ci / aarch64-linux-release (pull_request) Successful in 1h27m44s
ci / x86_64-linux-debug (pull_request) Successful in 1h33m9s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 1h34m49s
ci / aarch64-linux-debug (pull_request) Successful in 2h37m32s
ci / x86_64-linux-release (pull_request) Successful in 3h7m48s
ci / powerpc64le-linux-release (pull_request) Successful in 1h27m10s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h25m7s
ci / s390x-linux-debug (pull_request) Successful in 2h44m11s
ci / s390x-linux-release (pull_request) Successful in 1h43m8s
ci / loongarch64-linux-release (pull_request) Successful in 2h22m53s
ci / loongarch64-linux-debug (pull_request) Successful in 3h11m49s
2026年01月14日 03:57:22 +01:00 Compare
All checks were successful
ci / aarch64-macos-release (pull_request) Successful in 27m56s
Required
Details
ci / x86_64-freebsd-release (pull_request) Successful in 34m53s
Required
Details
ci / x86_64-windows-debug (pull_request) Successful in 41m10s
Required
Details
ci / x86_64-windows-release (pull_request) Successful in 44m1s
Required
Details
ci / x86_64-freebsd-debug (pull_request) Successful in 46m31s
Required
Details
ci / x86_64-openbsd-release (pull_request) Successful in 48m48s
Required
Details
ci / x86_64-openbsd-debug (pull_request) Successful in 56m9s
Required
Details
ci / aarch64-macos-debug (pull_request) Successful in 1h0m29s
Required
Details
ci / aarch64-linux-release (pull_request) Successful in 1h27m44s
Required
Details
ci / x86_64-linux-debug (pull_request) Successful in 1h33m9s
Required
Details
ci / x86_64-linux-debug-llvm (pull_request) Successful in 1h34m49s
Required
Details
ci / aarch64-linux-debug (pull_request) Successful in 2h37m32s
Required
Details
ci / x86_64-linux-release (pull_request) Successful in 3h7m48s
Required
Details
ci / powerpc64le-linux-release (pull_request) Successful in 1h27m10s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h25m7s
ci / s390x-linux-debug (pull_request) Successful in 2h44m11s
ci / s390x-linux-release (pull_request) Successful in 1h43m8s
ci / loongarch64-linux-release (pull_request) Successful in 2h22m53s
ci / loongarch64-linux-debug (pull_request) Successful in 3h11m49s
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u ez80:clevor-ez80
git switch clevor-ez80
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/n32
abi/sf
abi/x32
accepted

This proposal is planned.
arch/1750a
arch/21k
arch/6502
arch/a29k
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/avr32
arch/bfin
arch/bpf
arch/clipper
arch/colossus
arch/cr16
arch/cris
arch/csky
arch/dlx
arch/dsp16xx
arch/elxsi
arch/epiphany
arch/fr30
arch/frv
arch/h8300
arch/h8500
arch/hexagon
arch/hppa
arch/hppa64
arch/i370
arch/i860
arch/i960
arch/ia64
arch/ip2k
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/maxq
arch/mcore
arch/metag
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/mn10200
arch/mn10300
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/nios2
arch/ns32k
arch/nvptx
arch/or1k
arch/pdp10
arch/pdp11
arch/pj
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390
arch/s390x
arch/sh
arch/sh64
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/st200
arch/starcore
arch/tilegx
arch/tilepro
arch/tricore
arch/ts
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/we32k
arch/x86
arch/x86_16
arch/x86_64
arch/xcore
arch/xgate
arch/xstormy16
arch/xtensa
autodoc

The web application for interactive documentation and generation of its assets.
backend/c

The C backend outputs C source code.
backend/llvm

The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted

The self-hosted backends produce machine code directly.
binutils

Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking

Implementing this issue could cause existing code to no longer compile or have different behavior.
build system

The Zig build system - zig build, std.Build, the build runner, and package management.
debug info

An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs

An issue with documentation, e.g. the language reference or standard library doc comments.
error message

This issue points out an error message that is unhelpful and should be improved.
frontend

Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing

An issue related to Zig's integrated fuzz testing.
incremental

Reuse of internal compiler state for faster compilation.
lib/c

This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt

This issue relates to Zig's compiler-rt library.
lib/cxx

This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std

This issue relates to Zig's standard library.
lib/tsan

This issue relates to Zig's vendored libtsan.
lib/ubsan-rt

This issue relates to Zig's ubsan-rt library.
lib/unwind

This issue relates to Zig's vendored libunwind.
linking

Zig's integrated object file and incremental linker.
miscompilation

The compiler reports success but produces semantically incorrect code.
os/aix
os/android
os/bridgeos
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/kfreebsd
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/solaris
os/tvos
os/uefi
os/visionos
os/wali
os/wasi
os/watchos
os/windows
os/zos
proposal

This issue suggests modifications. If it also has the "accepted" label then it is planned.
release notes

This issue or pull request should be mentioned in the release notes.
testing

This issue is related to testing the compiler, standard library, or other parts of Zig.
tier system

This issue tracks the support tier for a target.
zig cc

Zig as a drop-in C-family compiler.
zig fmt

The Zig source code formatter.
bounty

https://ziglang.org/news/announcing-donor-bounties
bug

Observed behavior contradicts documented or intended behavior.
contributor-friendly

This issue is limited in scope and/or knowledge of project internals.
downstream

An issue with a third-party project that uses this project.
enhancement

Solving this issue will likely involve adding new logic or components to the codebase.
infra

An issue related to project infrastructure, e.g. continuous integration.
optimization

A task to improve performance and/or resource usage.
question

No questions on the issue tracker; use a community space instead.
regression

A bug that did not occur in a previous version.
upstream

An issue with a third-party project that this project uses.
No labels
abi/f32
abi/ilp32
abi/n32
abi/sf
abi/x32
accepted
arch/1750a
arch/21k
arch/6502
arch/a29k
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/avr32
arch/bfin
arch/bpf
arch/clipper
arch/colossus
arch/cr16
arch/cris
arch/csky
arch/dlx
arch/dsp16xx
arch/elxsi
arch/epiphany
arch/fr30
arch/frv
arch/h8300
arch/h8500
arch/hexagon
arch/hppa
arch/hppa64
arch/i370
arch/i860
arch/i960
arch/ia64
arch/ip2k
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/maxq
arch/mcore
arch/metag
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/mn10200
arch/mn10300
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/nios2
arch/ns32k
arch/nvptx
arch/or1k
arch/pdp10
arch/pdp11
arch/pj
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390
arch/s390x
arch/sh
arch/sh64
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/st200
arch/starcore
arch/tilegx
arch/tilepro
arch/tricore
arch/ts
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/we32k
arch/x86
arch/x86_16
arch/x86_64
arch/xcore
arch/xgate
arch/xstormy16
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/aix
os/android
os/bridgeos
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/kfreebsd
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/solaris
os/tvos
os/uefi
os/visionos
os/wali
os/wasi
os/watchos
os/windows
os/zos
proposal
release notes
testing
tier system
zig cc
zig fmt
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!30622
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "clevor/zig:ez80"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?