ziglang/zig
262
5.9k
Fork
You've already forked zig
763

add a fuzz test for zig fmt #30082

Merged
andrewrk merged 15 commits from gooncreeper/zig:fmt-fuzzing into master 2026年03月13日 08:43:22 +01:00
Contributor
Copy link

This fuzz test checks several properties of zig fmt are upheld, namely idempotency, textual equivilence, and no trailing whitespace.

All functions in the fuzz test have @disableInstrumentation for performance and since their branches are not interesting to the fuzzer.

Closes https://github.com/ziglang/zig/issues/10418
Closes https://github.com/ziglang/zig/issues/14654
Closes https://github.com/ziglang/zig/issues/15929
Closes https://github.com/ziglang/zig/issues/18088
Closes https://github.com/ziglang/zig/issues/20108
Closes https://github.com/ziglang/zig/issues/22778
Closes https://github.com/ziglang/zig/issues/23071
Closes https://github.com/ziglang/zig/issues/23722
Closes https://github.com/ziglang/zig/issues/24065
Closes #30080
Migrated from https://github.com/ziglang/zig/issues/23793 (conflicts, edits)

This fuzz test checks several properties of zig fmt are upheld, namely idempotency, textual equivilence, and no trailing whitespace. All functions in the fuzz test have @disableInstrumentation for performance and since their branches are not interesting to the fuzzer. Closes https://github.com/ziglang/zig/issues/10418 Closes https://github.com/ziglang/zig/issues/14654 Closes https://github.com/ziglang/zig/issues/15929 Closes https://github.com/ziglang/zig/issues/18088 Closes https://github.com/ziglang/zig/issues/20108 Closes https://github.com/ziglang/zig/issues/22778 Closes https://github.com/ziglang/zig/issues/23071 Closes https://github.com/ziglang/zig/issues/23722 Closes https://github.com/ziglang/zig/issues/24065 Closes #30080 Migrated from https://github.com/ziglang/zig/issues/23793 (conflicts, edits)
gooncreeper force-pushed fmt-fuzzing from 374cd51385
All checks were successful
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
ci / x86_64-windows-debug (pull_request) Successful in 43m18s
ci / x86_64-freebsd-release (pull_request) Successful in 47m58s
ci / x86_64-windows-release (pull_request) Successful in 49m17s
ci / x86_64-freebsd-debug (pull_request) Successful in 58m28s
ci / aarch64-macos-release (pull_request) Successful in 1h21m22s
ci / aarch64-macos-debug (pull_request) Successful in 1h37m42s
ci / aarch64-linux-debug (pull_request) Successful in 1h59m4s
ci / aarch64-linux-release (pull_request) Successful in 1h25m20s
ci / x86_64-linux-debug (pull_request) Successful in 1h44m43s
ci / s390x-linux-debug (pull_request) Successful in 2h51m38s
ci / s390x-linux-release (pull_request) Successful in 2h6m15s
ci / loongarch64-linux-release (pull_request) Successful in 2h14m21s
ci / loongarch64-linux-debug (pull_request) Successful in 3h19m43s
ci / x86_64-linux-release (pull_request) Successful in 4h19m37s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 7h11m55s
to 949ce40b1d
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 33m26s
ci / x86_64-freebsd-debug (pull_request) Successful in 43m10s
ci / aarch64-macos-release (pull_request) Successful in 44m52s
ci / x86_64-windows-release (pull_request) Successful in 48m5s
ci / aarch64-linux-release (pull_request) Successful in 1h20m55s
ci / aarch64-macos-debug (pull_request) Successful in 1h26m19s
ci / aarch64-linux-debug (pull_request) Successful in 1h44m31s
ci / x86_64-linux-debug (pull_request) Successful in 50m4s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 1h48m20s
ci / x86_64-linux-release (pull_request) Successful in 2h7m49s
ci / x86_64-windows-debug (pull_request) Successful in 42m41s
ci / s390x-linux-release (pull_request) Successful in 1h27m51s
ci / s390x-linux-debug (pull_request) Successful in 2h18m45s
ci / loongarch64-linux-release (pull_request) Successful in 2h14m51s
ci / loongarch64-linux-debug (pull_request) Successful in 3h28m45s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
2025年12月06日 17:34:46 +01:00 Compare
@ -1256,0 +1254,4 @@
'd',0,' ',0,'t',0,'w',0,'e',0,'n',0,'t',0,'y',0,'-',0,'s',0,'e',0,'v',0,'e',0,'n',0,' ',0,'A',0,
'S',0,'C',0,'I',0,'I',0,' ',0,'c',0,'h',0,'a',0,'r',0,'a',0,'c',0,'t',0,'e',0,'r',0,'s',0,
'¡',
0,
First-time contributor
Copy link

this doesn't seem right

this doesn't seem right
Contributor
Copy link

I recommend, as some other code does, defining const L = std.unicode.utf8ToUtf16LeStringLiteral; and using that here

I recommend, as some other code does, defining `const L = std.unicode.utf8ToUtf16LeStringLiteral;` and using that here
Author
Contributor
Copy link

The change in the formatting here is that expressions with unicode characters are now put on their own line. This avoids problems with aligning the columns since unicode text can take a variable amount of space to render and depends on the implementation (you can see this with the previous formatting and how the last zeros have an extra space before). Relevant are https://github.com/ziglang/zig/issues/15929 and the commit "zig fmt: rewrite renderArrayInit".

The change in the formatting here is that expressions with unicode characters are now put on their own line. This avoids problems with aligning the columns since unicode text can take a variable amount of space to render and depends on the implementation (you can see this with the previous formatting and how the last zeros have an extra space before). Relevant are https://github.com/ziglang/zig/issues/15929 and the commit "zig fmt: rewrite renderArrayInit".
First-time contributor
Copy link

ah, i misread that as a colon rather than an inverted exclamation mark, oops! i do still think that behaviour is a bit weird - i would expect it to put every element on its own line - but it seems to match the current behaviour for similar cases (eg. multi-line struct literals) so probably something to address separately ^-^

ah, i misread that as a colon rather than an inverted exclamation mark, oops! i do still think that behaviour is a bit weird - i would expect it to put *every* element on its own line - but it seems to match the current behaviour for similar cases (eg. multi-line struct literals) so probably something to address separately ^-^
gooncreeper marked this conversation as resolved
gooncreeper force-pushed fmt-fuzzing from 949ce40b1d
All checks were successful
ci / x86_64-freebsd-release (pull_request) Successful in 33m26s
ci / x86_64-freebsd-debug (pull_request) Successful in 43m10s
ci / aarch64-macos-release (pull_request) Successful in 44m52s
ci / x86_64-windows-release (pull_request) Successful in 48m5s
ci / aarch64-linux-release (pull_request) Successful in 1h20m55s
ci / aarch64-macos-debug (pull_request) Successful in 1h26m19s
ci / aarch64-linux-debug (pull_request) Successful in 1h44m31s
ci / x86_64-linux-debug (pull_request) Successful in 50m4s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 1h48m20s
ci / x86_64-linux-release (pull_request) Successful in 2h7m49s
ci / x86_64-windows-debug (pull_request) Successful in 42m41s
ci / s390x-linux-release (pull_request) Successful in 1h27m51s
ci / s390x-linux-debug (pull_request) Successful in 2h18m45s
ci / loongarch64-linux-release (pull_request) Successful in 2h14m51s
ci / loongarch64-linux-debug (pull_request) Successful in 3h28m45s
ci / riscv64-linux-debug (pull_request) Has been skipped
ci / riscv64-linux-release (pull_request) Has been skipped
to 02e8339ca7
Some checks failed
ci / aarch64-macos-release (pull_request) Successful in 1h20m1s
ci / aarch64-macos-debug (pull_request) Successful in 1h33m43s
ci / x86_64-netbsd-release (pull_request) Successful in 41m43s
ci / x86_64-freebsd-debug (pull_request) Successful in 56m59s
ci / x86_64-freebsd-release (pull_request) Successful in 45m57s
ci / x86_64-netbsd-debug (pull_request) Successful in 1h6m32s
ci / aarch64-linux-release (pull_request) Successful in 1h33m5s
ci / aarch64-linux-debug (pull_request) Successful in 2h24m5s
ci / x86_64-openbsd-debug (pull_request) Successful in 1h19m11s
ci / x86_64-openbsd-release (pull_request) Successful in 1h4m40s
ci / x86_64-linux-debug (pull_request) Successful in 1h13m31s
ci / x86_64-windows-debug (pull_request) Successful in 1h19m53s
ci / x86_64-windows-release (pull_request) Successful in 1h26m14s
ci / x86_64-linux-release (pull_request) Successful in 3h6m7s
ci / s390x-linux-release (pull_request) Successful in 1h50m53s
ci / x86_64-linux-debug-llvm (pull_request) Successful in 4h31m45s
ci / s390x-linux-debug (pull_request) Successful in 3h19m33s
ci / powerpc64le-linux-release (pull_request) Successful in 1h30m7s
ci / powerpc64le-linux-debug (pull_request) Successful in 4h28m1s
ci / aarch64-freebsd-debug (pull_request) Has been cancelled
ci / aarch64-freebsd-release (pull_request) Has been cancelled
ci / aarch64-netbsd-debug (pull_request) Has been cancelled
ci / aarch64-netbsd-release (pull_request) Has been cancelled
ci / loongarch64-linux-debug (pull_request) Has been cancelled
ci / loongarch64-linux-release (pull_request) Has been cancelled
ci / riscv64-linux-debug (pull_request) Has been cancelled
ci / riscv64-linux-release (pull_request) Has been cancelled
2026年03月12日 22:50:17 +01:00 Compare
@ -1708,3 +1708,3 @@
}
std.debug.print(" {s}{s}\n",.{
include.path,if(include.kind.isFramework())
include.path,
Owner
Copy link

can't say I'm a huge fan of this fmt change in particular, but I can't argue with all those bugs fixed. nice work.

can't say I'm a huge fan of this fmt change in particular, but I can't argue with all those bugs fixed. nice work.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
abi/f32
abi/ilp32
abi/sf
accepted
This proposal is planned.
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
The web application for interactive documentation and generation of its assets.
backend/c
The C backend outputs C source code.
backend/llvm
The LLVM backend outputs an LLVM bitcode module.
backend/self-hosted
The self-hosted backends produce machine code directly.
binutils
Zig's included binary utilities: zig ar, zig dlltool, zig lib, zig ranlib, zig objcopy, and zig rc.
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
build system
The Zig build system - zig build, std.Build, the build runner, and package management.
debug info
An issue related to debug information (e.g. DWARF) produced by the Zig compiler.
docs
An issue with documentation, e.g. the language reference or standard library doc comments.
error message
This issue points out an error message that is unhelpful and should be improved.
frontend
Tokenization, parsing, AstGen, ZonGen, Sema, Legalize, and Liveness.
fuzzing
An issue related to Zig's integrated fuzz testing.
incremental
Reuse of internal compiler state for faster compilation.
lib/c
This issue relates to Zig's libc implementation and/or vendored libcs.
lib/compiler-rt
This issue relates to Zig's compiler-rt library.
lib/cxx
This issue relates to Zig's vendored libc++ and/or libc++abi.
lib/std
This issue relates to Zig's standard library.
lib/tsan
This issue relates to Zig's vendored libtsan.
lib/ubsan-rt
This issue relates to Zig's ubsan-rt library.
lib/unwind
This issue relates to Zig's vendored libunwind.
linking
Zig's integrated object file and incremental linker.
miscompilation
The compiler reports success but produces semantically incorrect code.
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
This issue suggests language modifications. If it also has the "accepted" label then it is planned.
release notes
This issue or pull request should be mentioned in the release notes.
testing
This issue is related to testing the compiler, standard library, or other parts of Zig.
zig cc
Zig as a drop-in C-family compiler.
zig fmt
The Zig source code formatter.
zig reduce
The Zig source code reduction tool.
bounty
https://ziglang.org/news/announcing-donor-bounties
bug
Observed behavior contradicts documented or intended behavior.
contributor-friendly
This issue is limited in scope and/or knowledge of project internals.
downstream
An issue with a third-party project that uses this project.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
infra
An issue related to project infrastructure, e.g. continuous integration.
optimization
A task to improve performance and/or resource usage.
question
No questions on the issue tracker; use a community space instead.
regression
Something that used to work in a previous version stopped working
upstream
An issue with a third-party project that this project uses.
use case
Describes a real use case that is difficult or impossible, but does not propose a solution.
No labels
abi/f32
abi/ilp32
abi/sf
accepted
arch/21k
arch/6502
arch/aarch64
arch/alpha
arch/amdgcn
arch/arc
arch/arc32
arch/arc64
arch/arm
arch/avr
arch/bfin
arch/bpf
arch/colossus
arch/cris
arch/csky
arch/dlx
arch/epiphany
arch/fr30
arch/frv
arch/hexagon
arch/hppa
arch/hppa64
arch/ia64
arch/kalimba
arch/kvx
arch/lanai
arch/lm32
arch/loongarch32
arch/loongarch64
arch/m32r
arch/m68k
arch/m88k
arch/mcore
arch/microblaze
arch/mips
arch/mips64
arch/mmix
arch/moxie
arch/mrisc32
arch/msp430
arch/nds32
arch/ns32k
arch/nvptx
arch/or1k
arch/powerpc
arch/powerpc64
arch/propeller
arch/riscv32
arch/riscv64
arch/rl78
arch/rx
arch/s390x
arch/sh
arch/sparc
arch/sparc64
arch/spirv
arch/spu
arch/tricore
arch/v850
arch/vax
arch/vc4
arch/ve
arch/wasm
arch/x86
arch/x86_64
arch/xcore
arch/xtensa
autodoc
backend/c
backend/llvm
backend/self-hosted
binutils
breaking
build system
debug info
docs
error message
frontend
fuzzing
incremental
lib/c
lib/compiler-rt
lib/cxx
lib/std
lib/tsan
lib/ubsan-rt
lib/unwind
linking
miscompilation
os/android
os/contiki
os/dragonfly
os/driverkit
os/emscripten
os/freebsd
os/fuchsia
os/haiku
os/hermit
os/hurd
os/illumos
os/ios
os/linux
os/maccatalyst
os/macos
os/managarm
os/netbsd
os/ohos
os/openbsd
os/plan9
os/redox
os/rtems
os/serenity
os/tvos
os/uefi
os/visionos
os/wasi
os/watchos
os/windows
proposal
release notes
testing
zig cc
zig fmt
zig reduce
bounty
bug
contributor-friendly
downstream
enhancement
infra
optimization
question
regression
upstream
use case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ziglang/zig!30082
Reference in a new issue
ziglang/zig
No description provided.
Delete branch "gooncreeper/zig:fmt-fuzzing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?