ziglang/zig.vim

Fork 2

Code Issues 19 Pull requests 5 Activity

fix escape characters being forcefully inserted when calling 'zig env' #106

Open

Gogopex wants to merge 2 commits from Gogopex/master into master

pull from: Gogopex/master

merge into: ziglang:master

ziglang:master

ziglang:hb/new-keywords

ziglang:mikdusan-zir

Conversation 0 Commits 2 Files changed 1 +9 -3

Gogopex commented

2024年07月28日 16:06:46 +02:00

(Migrated from github.com)

Copy link

Fixes: https://github.com/ziglang/zig.vim/issues/105

This removes escape characters being inserted due to various shells configurations. I think the -- plain can technically be dropped, as escape characters for color rendering are inserted regardless.

I also tried solutions with:

--color off (it led me to realize it was shell related)
forcing a clean env during this scope (but I think it'd run into cross-platform issues)
adding version checking as --plain was introduced in ~0.11, but I don't believe it is needed in the end.

cc: @melenaus

Fixes: https://github.com/ziglang/zig.vim/issues/105 This removes escape characters being inserted due to various shells configurations. I think the `-- plain` can technically be dropped, as escape characters for color rendering are inserted regardless. I also tried solutions with: - `--color off` (it led me to realize it was shell related) - forcing a clean `env` during this scope (but I think it'd run into cross-platform issues) - adding version checking as `--plain` was introduced in ~0.11, but I don't believe it is needed in the end. cc: @melenaus

This pull request has changes conflicting with the target branch.

ftplugin/zig.vim

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin Gogopex/master:Gogopex/master

git switch Gogopex/master

Reviewers

No reviewers

Labels

Clear labels

bounty

https://ziglang.org/news/announcing-donor-bounties

bug

Observed behavior contradicts documented or intended behavior.

contributor-friendly

This issue is limited in scope and/or knowledge of project internals.

downstream

An issue with a third-party project that uses this project.

enhancement

Solving this issue will likely involve adding new logic or components to the codebase.

infra

optimization

A task to improve performance and/or resource usage.

question

No questions on the issue tracker; use a community space instead.

regression

A bug that did not occur in a previous version.

upstream

An issue with a third-party project that this project uses.

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ziglang/zig.vim!106

No description provided.

Delete branch "Gogopex/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?