1
2
Fork
You've already forked spin
0

Chore: fix cargo clippy warnings #186

Open
funny0facer wants to merge 2 commits from funny0facer/clippy into master
pull from: funny0facer/clippy
merge into: zesterer:master
zesterer:master
zesterer:fixes
zesterer:fix-ub
zesterer:revert-127-ci
zesterer:spinlock
funny0facer commented 2026年01月26日 22:13:27 +01:00 (Migrated from github.com)
Copy link

I ran cargo clippy and got some warnings. Those were removed with the first commit.
After that, I checked if there were any #[allow] sections. => Therefore I replaced the deprecated spin_loop with the newer upstream solution.

I ran cargo clippy and got some warnings. Those were removed with the first commit. After that, I checked if there were any #[allow] sections. => Therefore I replaced the deprecated spin_loop with the newer upstream solution.
zesterer (Migrated from github.com) approved these changes 2026年02月05日 19:06:14 +01:00
zesterer (Migrated from github.com) left a comment
Copy link

Thanks, just one comment.

Thanks, just one comment.
@ -29,3 +26,3 @@
core::sync::atomic::spin_loop_hint();
core::hint::spin_loop();
}
}
zesterer (Migrated from github.com) commented 2026年02月05日 19:05:54 +01:00
Copy link

Have you checked that this no longer applies with our MSRV?

Have you checked that this no longer applies with our MSRV?
funny0facer (Migrated from github.com) reviewed 2026年02月05日 20:27:54 +01:00
@ -29,3 +26,3 @@
core::sync::atomic::spin_loop_hint();
core::hint::spin_loop();
}
}
funny0facer (Migrated from github.com) commented 2026年02月05日 20:27:54 +01:00
Copy link

I am not sure what you mean.

From our Cargo.toml: rust-version = "1.71"

hint::spin_loop() is in rust since 1.49.0 (https://doc.rust-lang.org/src/core/hint.rs.html#268-295) and spin_loop_hint() is deprecated since 1.51.0 (https://doc.rust-lang.org/src/core/sync/atomic.rs.html#4608-4613)

I am not sure what you mean. From our Cargo.toml: `rust-version = "1.71"` hint::spin_loop() is in rust since 1.49.0 (https://doc.rust-lang.org/src/core/hint.rs.html#268-295) and spin_loop_hint() is deprecated since 1.51.0 (https://doc.rust-lang.org/src/core/sync/atomic.rs.html#4608-4613)
This pull request has changes conflicting with the target branch.
  • src/rwlock.rs
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin funny0facer/clippy:funny0facer/clippy
git switch funny0facer/clippy

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff funny0facer/clippy
git switch funny0facer/clippy
git rebase master
git switch master
git merge --ff-only funny0facer/clippy
git switch funny0facer/clippy
git rebase master
git switch master
git merge --no-ff funny0facer/clippy
git switch master
git merge --squash funny0facer/clippy
git switch master
git merge --ff-only funny0facer/clippy
git switch master
git merge funny0facer/clippy
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
zesterer/spin!186
Reference in a new issue
zesterer/spin
No description provided.
Delete branch "funny0facer/clippy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?