Add values sidebar #19

aaaaargZombies commented 2021年10月06日 17:30:20 +02:00

• Align values content with left.
• Add values summary sidebar.

- Align values content with left. - Add values summary sidebar.

SamWhited commented 2021年10月07日 02:45:07 +02:00

I'm not sure how I feel about this part of the design; it still feels a bit out of place to me. Maybe if this section were longer the navigation would make sense, but as is it just feels like the titles are next to the same titles and it's not all that helpful. It doesn't look bad, but also feels a little out of place to me. Not that I'd block either way, I just think it might be worth thinking more about the functionality of this sort of thing before we add extra elements to the page.

EDIT: ignore this, after seeing the rendered final version in your issue I think it's irrelvant. That one actually requires scrolling and the titles make more sense.

I'm not sure how I feel about this part of the design; it still feels a bit out of place to me. Maybe if this section were longer the navigation would make sense, but as is it just feels like the titles are next to the same titles and it's not all that helpful. It doesn't look bad, but also feels a little out of place to me. Not that I'd block either way, I just think it might be worth thinking more about the functionality of this sort of thing before we add extra elements to the page. **EDIT:** ignore this, after seeing the rendered final version in your issue I think it's irrelvant. That one actually requires scrolling and the titles make more sense.

aaaaargZombies commented 2021年10月07日 08:21:30 +02:00

Yeah I'm trying to make these pull requests incremental so it's reasonable for somone to actually check the code but that does mean it can feel a bit like "why's this like that, where's it going"

From reading through all our discussions on values it seems like we might end up with more points in there by the time it's finalized.

Yeah I'm trying to make these pull requests incremental so it's reasonable for somone to actually check the code but that does mean it can feel a bit like "why's this like that, where's it going" From reading through all our discussions on values it seems like we might end up with more points in there by the time it's finalized.

aaaaargZombies commented 2021年10月11日 11:48:02 +02:00

Can I merge this?

Can I merge this?

SamWhited commented 2021年10月11日 12:31:56 +02:00

Some of these CSS changes will break the team page I believe, we should make sure that still looks the same before merging.

Some of these CSS changes will break the team page I believe, we should make sure that still looks the same before merging.

aaaaargZombies commented 2021年10月11日 12:53:22 +02:00

Both* look pretty broken to my eyes but in different ways.

The two don't share a generic section type so should we create new one for the team or the values?

edit: * versions of the team page I mean

Both* look pretty broken to my eyes but in different ways. The two don't share a generic section type so should we create new one for the team or the values? **edit**: * versions of the team page I mean

SamWhited commented 2021年10月11日 12:55:21 +02:00

That seems fine too, but I have no real preference

That seems fine too, but I have no real preference

aaaaargZombies commented 2021年10月11日 22:23:47 +02:00

Hopefully if we merge #23 first there won't be any problems.

Hopefully if we merge #23 first there won't be any problems.

aaaaargZombies commented 2021年10月18日 22:48:12 +02:00

@SamWhited any thoughts regarding merging #23 then this one?

I'd also like to make the contain_content branch into a PR to resolve the #20 but I built it ontop of this branch because I thought we'd be able to merge this in soon. Maybe that was a mistake.

@SamWhited any thoughts regarding merging #23 then this one? I'd also like to make the `contain_content` branch into a PR to resolve the #20 but I built it ontop of this branch because I thought we'd be able to merge this in soon. Maybe that was a mistake.

SamWhited commented 2021年10月19日 12:26:01 +02:00

I'm not a fan of the sidebar personally; maybe @nthall feels differently and would be comfortable merging? The HTML/CSS itself looks fine though (although, minor nit, I know, but I'd merge #23 into this branch then merge the whole thing at once to avoid both builds, the split on this one also seems weird to me as they're the same feature).

I'm not a fan of the sidebar personally; maybe @nthall feels differently and would be comfortable merging? The HTML/CSS itself looks fine though (although, minor nit, I know, but I'd merge #23 into this branch then merge the whole thing at once to avoid both builds, the split on this one also seems weird to me as they're the same feature).

aaaaargZombies commented 2021年10月19日 15:37:17 +02:00

I'm not a fan of the sidebar personally; maybe @nthall feels differently and would be comfortable merging?

I'm at a bit of a loss here. I think there's some failure in our decision making process and our ability to co-oporate. My undertanding was that I made a design and asked for feedback. People gave the greenlight.

This predates our discussion of a decision making process but it fits pretty neatly into the make propsal/seek concensus model.

Based on this I have been trying to implement this design for about 2 months.

It's very hard to collaborate if we're not working towards the same goal. I would like you to either support me in implenting the proposed design or put forward an alternative / revised proposal so we can start to navigate by some shared landmarks.

> I'm not a fan of the sidebar personally; maybe @nthall feels differently and would be comfortable merging? I'm at a bit of a loss here. I think there's some failure in our decision making process and our ability to co-oporate. My undertanding was that I made a design and asked for feedback. People gave the greenlight. This predates our discussion of a decision making process but it fits pretty neatly into the make propsal/seek concensus model. Based on this I have been trying to implement this design for about 2 months. It's very hard to collaborate if we're not working towards the same goal. I would like you to either support me in implenting the proposed design or put forward an alternative / revised proposal so we can start to navigate by some shared landmarks.

SamWhited commented 2021年10月19日 16:06:54 +02:00

My proposal is that the current design for that section is fine as is; the new one doesn't look bad or anything, but requires JavaScript which I dont' think should be used (I know that doesn't exist yet, but it was part of the bit of the original design you're trying to implement). I have also just decided that it looks better without the extra elements personally, but I'm not blocking merging by any means, I just don't think I'm the person to review the design portion of it. The CSS/HTML looks okay though.

My proposal is that the current design for that section is fine as is; the new one doesn't look bad or anything, but requires JavaScript which I dont' think should be used (I know that doesn't exist yet, but it was part of the bit of the original design you're trying to implement). I have also just decided that it looks better without the extra elements personally, but I'm not blocking merging by any means, I just don't think I'm the person to review the design portion of it. The CSS/HTML looks okay though.

aaaaargZombies commented 2021年10月19日 17:42:03 +02:00

I just don't think I'm the person to review the design portion of it

Everyone should feel comfortable with the design and your input is as important as everyone else.

The difficulty is that you've effectively created a redesign without articulating your motivations. From my point of view it's been impossible to tell if you don't care about the design, didn't like the design and used the implementation as an opportunity to make changes or struggled to accurately reproduce it.

This is more a decision making and teamwork issue than a design one. We should be mindful of opportunities for informal hierarchies to emerge and "first one to code it wins" would be a good one.

I don't think you've done anything malicious and I've appreciated your enthusiasm and all the work you’ve put into getting this off the ground but I also feel like we could have got more done in the time we had with better processes.

Anyway I've no idea how tone has been conveyed through text so I'll be explicit, I am frustrated but not angry. I am glad that the website is serving it's purpose as a low stakes project where we can figure out how to work with each other and encounter these issues in a risk free environment.

> I just don't think I'm the person to review the design portion of it Everyone should feel comfortable with the design and your input is as important as everyone else. The difficulty is that you've effectively created a redesign without articulating your motivations. From my point of view it's been impossible to tell if you don't care about the design, didn't like the design and used the implementation as an opportunity to make changes or struggled to accurately reproduce it. This is more a decision making and teamwork issue than a design one. We should be mindful of opportunities for informal hierarchies to emerge and "first one to code it wins" would be a good one. I don't think you've done anything malicious and I've appreciated your enthusiasm and all the work you’ve put into getting this off the ground but I also feel like we could have got more done in the time we had with better processes. Anyway I've no idea how tone has been conveyed through text so I'll be explicit, I am frustrated but not angry. I am glad that the website is serving it's purpose as a low stakes project where we can figure out how to work with each other and encounter these issues in a risk free environment.

nthall commented 2021年10月19日 19:36:50 +02:00

I'm sorry for not joining this conversation sooner. It kind of sounds like the core problem here is one of process rather than design or implementation (btw I think it looks sharp but agree that without more content it's more distracting than helpful). The added perspective I want to provide is: how crucial is a clean, carefully tended commit history for a brand-new static site, compared to the value of staying out of the weeds?

And the second thing I want to offer is: perhaps it would be easiest to close this MR and #23 in favor of one that combines both sets of changes, as was discussed here. I've created exactly such a branch at combine_values_changes . It's fast-forward ready for main. What do y'all say?

I'm sorry for not joining this conversation sooner. It kind of sounds like the core problem here is one of process rather than design or implementation (btw I think it looks sharp but agree that without more content it's more distracting than helpful). The added perspective I want to provide is: how crucial is a clean, carefully tended commit history for a brand-new static site, compared to the value of staying out of the weeds? And the second thing I want to offer is: perhaps it would be easiest to close this MR and #23 in favor of one that combines both sets of changes, as was discussed here. I've created exactly such a branch at [combine_values_changes](https://codeberg.org/willowbark/web/src/branch/combine_values_changes) . It's fast-forward ready for main. What do y'all say?

SamWhited commented 2021年10月20日 14:12:12 +02:00

I definitely think it would make more sense if these were part of the same patch set. Merging #23 into this branch instead of to main should be sufficient and we can squash later if needed.

As for merging to main, as mentioned above my vote is a slightly downward tilting hand. I certainly wouldn't -1 it, but I don't personally love it either.

I definitely think it would make more sense if these were part of the same patch set. Merging #23 into this branch instead of to main should be sufficient and we can squash later if needed. As for merging to main, as mentioned above my vote is a slightly downward tilting hand. I certainly wouldn't -1 it, but I don't personally love it either.

aaaaargZombies commented 2021年10月27日 14:25:49 +02:00

OK I took @nthall up on the offer and merged their branch as @SamWhited was only a slight down vote and I was obviously very keen.

OK I took @nthall up on the offer and merged their branch as @SamWhited was only a slight down vote and I was obviously very keen.