webxdc/xdcget
16
14
Fork
You've already forked xdcget
41

fix: don't break if an app has no dash #316

Open
WofWca wants to merge 1 commit from fix-no-author-name into main
pull from: fix-no-author-name
merge into: webxdc:main
webxdc:main
webxdc:experintellia/add-tools
webxdc:wofwca-patch-1
webxdc:adb/update-arcanecircle-apps
webxdc:septias-patch-1
webxdc:adb/add-pixelit-update-ruffle
webxdc:adb/fix-tcm-category
webxdc:hpk/remove-lock
webxdc:hpk/fix-ci
webxdc:adb/update-super-castle
webxdc:hpk/simplify-3-storage
webxdc:adb/issue-56
webxdc:adb/add-gitea-support
webxdc:adb/code-tweaks
webxdc:adb/issue-62
webxdc:hpk/better_checks
webxdc:adb/use-env-vars
webxdc:adb/issue-22
webxdc:hpk/export-zip

Sometimes people submit apps not knowing that we expect them
to format the app id as {author}-{name} (with a dash).
When such MRs get merged, the store stops updating
because the update script throws.
See e.g. this #300.
Let's not throw.

I have not tested this
(apart from playing around with the Python interpreter in my console).

Sometimes people submit apps not knowing that we expect them to format the app id as `{author}-{name}` (with a dash). When such MRs get merged, the store stops updating because the update script throws. See e.g. this https://codeberg.org/webxdc/xdcget/pulls/300. Let's not throw. I have not tested this (apart from playing around with the Python interpreter in my console).
fix: don't break if an app has no dash
Some checks failed
/ test (push) Has been cancelled
9e54ccde37
Sometimes people submit apps not knowing that we expect them
to format the app id as `{author}-{name}` (with a dash).
When such MRs get merged, the store stops updating
because the update script throws.
See e.g. this #300.
Let's not throw.
Some checks failed
/ test (push) Has been cancelled
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix-no-author-name:fix-no-author-name
git switch fix-no-author-name
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/xdcget!316
Reference in a new issue
webxdc/xdcget
No description provided.
Delete branch "fix-no-author-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?