17
3
Fork
You've already forked split-bill
2

state management refactor #4

Closed
nonetoohappy wants to merge 2 commits from ac/state-management-refactor into ac/prettier-fix
pull from: ac/state-management-refactor
merge into: webxdc:ac/prettier-fix
webxdc:main
webxdc:ac/prettier-fix
Collaborator
Copy link

Note: Currently points to #3 to make the diff easier to read. Will update when that's merged.

Notable changes:

  • Updates state management that deals with Yjs to use useSyncExternalStore(), which greatly simplifies and reduces the amount of code needed to get state based on Yjs by making Yjs the one source of truth for state based on it (no more state syncing with useState() + useEffect())

  • Removes unnecessary usages of useState() to derive state that can be directly calculated

_Note: Currently points to #3 to make the diff easier to read. Will update when that's merged._ Notable changes: - Updates state management that deals with Yjs to use [`useSyncExternalStore()`](https://react.dev/learn/you-might-not-need-an-effect#subscribing-to-an-external-store), which greatly simplifies and reduces the amount of code needed to get state based on Yjs by making Yjs the one source of truth for state based on it (no more state syncing with `useState() + useEffect()`) - Removes unnecessary usages of `useState()` to derive state that can be [directly calculated](https://react.dev/learn/you-might-not-need-an-effect#updating-state-based-on-props-or-state)
durian changed title from (削除) WIP: state management refactor (削除ここまで) to state management refactor 2025年01月05日 18:11:02 +01:00
First-time contributor
Copy link

Merged to main!

Merged to main!
durian closed this pull request 2025年01月05日 18:11:32 +01:00
durian deleted branch ac/state-management-refactor 2025年01月05日 18:11:50 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/split-bill!4
Reference in a new issue
webxdc/split-bill
No description provided.
Delete branch "ac/state-management-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?