Add gain node for audio #9

link2xt commented 2024年10月21日 19:10:26 +02:00

Makes this less loud and increases/decreases gain smoothly when update arrives or when there are no more updates.

Makes this less loud and increases/decreases gain smoothly when update arrives or when there are no more updates.

link2xt commented 2024年10月21日 19:13:19 +02:00

Oscillator and gain nodes should be made persistent and when a new update arrives if the sound is already playing we should not decrease the value to 0 but keep playing the sound.

What is annoying about the current beeping sound is that it starts and stops all the time.
E.g. try https://tonejs.github.io/examples/envelope and hold the button. It is much less annoying than when you click it repeatedly.

Oscillator and gain nodes should be made persistent and when a new update arrives if the sound is already playing we should not decrease the value to 0 but keep playing the sound. What is annoying about the current beeping sound is that it starts and stops all the time. E.g. try https://tonejs.github.io/examples/envelope and hold the button. It is much less annoying than when you click it repeatedly.

r10s commented 2024年10月23日 01:02:27 +02:00

for feedback, i am wondering, if it isn't better to also play a sound when the mouse button is pressed (so when drawing starts, first pixel is sent). currently, it is only played when drawing ends, which make things appear a bit slower and laggy.

maybe one could also play a sound that lasts, say 2 seconds, and fades out (this is probably sustain parameter)

for feedback, i am wondering, if it isn't better to also play a sound when the mouse button is pressed (so when drawing starts, first pixel is sent). currently, it is only played when drawing ends, which make things appear a bit slower and laggy. maybe one could also play a sound that lasts, say 2 seconds, and fades out (this is probably sustain parameter)

link2xt commented 2024年10月23日 06:59:48 +02:00

for feedback, i am wondering, if it isn't better to also play a sound when the mouse button is pressed (so when drawing starts, first pixel is sent). currently, it is only played when drawing ends, which make things appear a bit slower and laggy.

Sound is played when update is received. We only send update when mouse is released with all the pixels added/removed since mouse was pressed.

> for feedback, i am wondering, if it isn't better to also play a sound when the mouse button is pressed (so when drawing starts, first pixel is sent). currently, it is only played when drawing ends, which make things appear a bit slower and laggy. Sound is played when update is received. We only send update when mouse is released with all the pixels added/removed since mouse was pressed.

This pull request can be merged automatically.

You are not authorized to merge this pull request.