webxdc/editor
16
9
Fork
You've already forked editor
2

WIP: target legacy browsers #49

Closed
WofWca wants to merge 1 commit from target-legacy into main
pull from: target-legacy
merge into: webxdc:main
webxdc:main
webxdc:tooling
webxdc:add-presence
webxdc:link2xt/autosave-interval-limit
webxdc:hpk/tryquill
webxdc:hpk/cleanup-indexhtml
webxdc:inline-b64
webxdc:webxdc-x-web-version
webxdc:pages-demo
webxdc:status-string
webxdc:toolbar-position-sticky

This should make it work in older browsers (WebViews) by polyfilling (and maybe something else?) the features that are used in the code, but are not supported by older browsers, like optional chaining.

I haven't actually tested it on such older browsers.

See webxdc/checklist#22

TODO:

  • As @adb tested, this makes is stop working (white screen).

Debugging tip on Desktop:

(削除) place a breakpoint on fill_up_connections
in webxdc-wrapper.html, step into then reset numIterations to 0
after the numIterations = 50 line has been executed (削除ここまで)

In dev tools, select the index.html context and execute location.reload().

This should make it work in older browsers (WebViews) by polyfilling (and maybe something else?) the features that are used in the code, but are not supported by older browsers, like optional chaining. I haven't actually tested it on such older browsers. See https://codeberg.org/webxdc/checklist/pulls/22 TODO: - [ ] As @adb tested, this makes is stop working (white screen). Debugging tip on Desktop: ~~place a breakpoint on `fill_up_connections` in `webxdc-wrapper.html`, step into then reset `numIterations` to 0 after the `numIterations = 50` line has been executed~~ In dev tools, select the `index.html` context and execute `location.reload()`.

the .browserlistrc file is missing, check the file from the checklist repo.

would be great if you make this work!

the .browserlistrc file is missing, check the file from the checklist repo. would be great if you make this work!
Owner
Copy link

@adbenitez @WofWca what is blocking/missing to get this in?

once this is merged, we should also do a new release

@adbenitez @WofWca what is blocking/missing to get this in? once this is merged, we should also do a new release
Author
Owner
Copy link

what is blocking/missing to get this in?

this makes is stop working (white screen)

> what is blocking/missing to get this in? > this makes is stop working (white screen)
Owner
Copy link

could you rebase this, and please in general spend a bit more effort describing in the PR main description the issue being addressed, and how? By linking to a discusssion in some other thread you are off-loading this interpretation work to all readers.

could you rebase this, and please in general spend a bit more effort describing in the PR main description the issue being addressed, and how? By linking to a discusssion in some other thread you are off-loading this interpretation work to all readers.
Author
Owner
Copy link

I rebased it and updated the description.

I rebased it and updated the description.
Owner
Copy link

i ran "npm run build" and then put the resulting dist-release/editor.xdc (195K instead of 151K) into a chat -- but starting yields an empty screen. Does this basic test work for you?

i ran "npm run build" and then put the resulting dist-release/editor.xdc (195K instead of 151K) into a chat -- but starting yields an empty screen. Does this basic test work for you?
Author
Owner
Copy link

but starting yields an empty screen

Precisely. It doesn't work for me either. This is why the MR is marked as WIP.

> but starting yields an empty screen Precisely. It doesn't work for me either. This is why the MR is marked as WIP.
Owner
Copy link

Closing this PR because it's factually stale. Can we revived if needed.

Closing this PR because it's factually stale. Can we revived if needed.
hpk closed this pull request 2024年10月17日 12:08:19 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/editor!49
Reference in a new issue
webxdc/editor
No description provided.
Delete branch "target-legacy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?