webxdc/editor
16
9
Fork
You've already forked editor
2

feat: add element with last editors #37

Closed
WofWca wants to merge 2 commits from status-string into main
pull from: status-string
merge into: webxdc:main
webxdc:main
webxdc:tooling
webxdc:add-presence
webxdc:link2xt/autosave-interval-limit
webxdc:hpk/tryquill
webxdc:hpk/cleanup-indexhtml
webxdc:target-legacy
webxdc:inline-b64
webxdc:webxdc-x-web-version
webxdc:pages-demo
webxdc:toolbar-position-sticky

Closes #21

TODO:

  • Styles
  • Change date format? Relative?
  • It seems to work alright, but idk, maybe still need to refactor, because main.js still seems to assume that if the ydoc was changed it necessarily means that the contents of the Prosemirror editor were changed, which is not the case since this MR.
    Done: added a comment in main.js
  • Address new TODOs
  • Get other people to test it, get feedback

image

Closes https://codeberg.org/webxdc/editor/issues/21 TODO: - [x] Styles - [x] Change date format? Relative? - [x] It seems to work alright, but idk, maybe still need to refactor, because `main.js` still seems to assume that if the `ydoc` was changed it necessarily means that the contents of the Prosemirror editor were changed, which is not the case since this MR. Done: added a comment in `main.js` - [x] Address new TODOs - [ ] Get other people to test it, get feedback ![image](/attachments/1b2bbfea-639b-47ee-b098-796c0f6d9414)
Owner
Copy link

Layout:

  • the status line should be one line of text only, with as short text as possible

  • we should add a light line between status-line and text-inout and use a lighter font, maybe #888 to start with, that should be fine for dark as well as for light mode (btw. the blue dark is weird, but that is another issue and not important :)

Date format:

  • toLocaleString() seems good enough for now if the date is not today

  • if the date is on today, i'd shorten that to toLocaleTimeString, this saves quite some space in many cases

Layout: - the status line should be one line of text only, with as short text as possible - we should add a light line between status-line and text-inout and use a lighter font, maybe #888 to start with, that should be fine for dark as well as for light mode (btw. the blue dark is weird, but that is another issue and not important :) Date format: - `toLocaleString()` seems good enough for now if the date is not today - if the date is on today, i'd shorten that to `toLocaleTimeString`, this saves quite some space in many cases
Author
Owner
Copy link

One two buckle my <footer>.
Editor.xdc attached.

image

One two buckle my `<footer>`. `Editor.xdc` attached. ![image](/attachments/98c3a8fd-480e-4906-a709-713b97deef98)
WofWca changed title from (削除) WIP: feat: add element with last editors (削除ここまで) to feat: add element with last editors 2023年09月06日 11:02:51 +02:00
Owner
Copy link

thanks for pushing that forward and to give us the option to have a status bar.

although i also voted for the original issue 2month ago, i am meanwhile not 100% sure if the status bar makes sense in its current form, it adds comparable few benefits but somehow removes the "ease" of the UI.

maybe that could be improved by CSS and rewording, need to think over that.

for feedback, we meanwhile also have more info-messages as of #51 - maybe this is already good enough, we should give that a try

thanks for pushing that forward and to give us the option to have a status bar. although i also voted for the original issue 2month ago, i am meanwhile not 100% sure if the status bar makes sense in its current form, it adds comparable few benefits but somehow removes the "ease" of the UI. maybe that could be improved by CSS and rewording, need to think over that. for feedback, we meanwhile also have more info-messages as of https://codeberg.org/webxdc/editor/issues/51 - maybe this is already good enough, we should give that a try
Owner
Copy link

closing this as main branch has diverged -- if we tackle a status bar again, we can revive it or use it as reference.

closing this as main branch has diverged -- if we tackle a status bar again, we can revive it or use it as reference.
hpk closed this pull request 2023年09月21日 16:28:51 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/editor!37
Reference in a new issue
webxdc/editor
No description provided.
Delete branch "status-string"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?