webxdc/editor
16
9
Fork
You've already forked editor
2

WIP: tooling update #113

Draft
faassen wants to merge 18 commits from tooling into main
pull from: tooling
merge into: webxdc:main
webxdc:main
webxdc:add-presence
webxdc:link2xt/autosave-interval-limit
webxdc:hpk/tryquill
webxdc:hpk/cleanup-indexhtml
webxdc:target-legacy
webxdc:inline-b64
webxdc:webxdc-x-web-version
webxdc:pages-demo
webxdc:status-string
webxdc:toolbar-position-sticky

This contains a whole bunch of updates, but no functional changes. The churn in the overall diff is big because of reformatting and moving files being part of it, but I tried to break it into individual commits which are easier to review.

The overall aim was to upgrade this to align with y-webxdc where possible in the names of scripts, tools used, configuration, etc. This produces an application, not a library, so there are some differences, but
it's still nice to use the same approach in multiple places. It also helped validate recent y-webxdc changes, which brings me to one thing that still makes this thing WIP: it's depending on an unreleased version of y-webxdc (and in fact required a tweak to y-webxdc to make this possible). A y-webxdc release is required to unblock this PR.

Summary of changes:

  • uses typescript now with strict type checks. Uses the y-webxdc types, @types/webxdc too

  • consistent build scripts with those in y-webxdc

  • upgrade to vite 8

  • clean out some old document comments carried over from prosemirror example

  • applied standard prettier (like in y-webxdc)

  • upgraded eslint and configured it for ts too

This contains a whole bunch of updates, but no functional changes. The churn in the overall diff is big because of reformatting and moving files being part of it, but I tried to break it into individual commits which are easier to review. The overall aim was to upgrade this to align with y-webxdc where possible in the names of scripts, tools used, configuration, etc. This produces an application, not a library, so there are some differences, but it's still nice to use the same approach in multiple places. It also helped validate recent y-webxdc changes, which brings me to one thing that still makes this thing WIP: it's depending on an unreleased version of y-webxdc (and in fact required a tweak to y-webxdc to make this possible). A y-webxdc release is required to unblock this PR. Summary of changes: * uses typescript now with strict type checks. Uses the `y-webxdc types`, `@types/webxdc` too * consistent build scripts with those in y-webxdc * upgrade to vite 8 * clean out some old document comments carried over from prosemirror example * applied standard prettier (like in y-webxdc) * upgraded eslint and configured it for ts too 
for consistency with y-webxdc. pnpm has a few mechanisms to prevent
some attacks (minimum release age, blocking install scripts)
We don't reformat yet, we'll do that in a seperate commit.
Go to default prettier formatting, just like y-webxdc: it avoids debates 
as it's "whatever prettier does".
Analogous to 'y-webxdc'
We don't check anything yet. In fact we had to turn *off* a typecheck comment
on schema.js as it started failing. We'll get back to that when we add proper types.
This is still a tolerant typecheck, but had to annotate various things to make it pass TS.
we inherited getdocs comments from the schema we adapted, but we're not using getdocs
and aren't going to. getdocs (https://github.com/marijnh/getdocs) is a documentation tool created
by the author of prosemirror.
This is right now depending on a git version of y-webxdc, as this is a good
testbed to see whether the changes made sense.
This requires an update to y-prosemirror as there was a bug in v1.2.1 that didn't
export its types.
pnpm should prevent this so we are less vulnerable to supply chain attacks.
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin tooling:tooling
git switch tooling

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff tooling
git switch tooling
git rebase main
git switch main
git merge --ff-only tooling
git switch tooling
git rebase main
git switch main
git merge --no-ff tooling
git switch main
git merge --squash tooling
git switch main
git merge --ff-only tooling
git switch main
git merge tooling
git push origin main
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/editor!113
Reference in a new issue
webxdc/editor
No description provided.
Delete branch "tooling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?