webxdc/checklist
15
2
Fork
You've already forked checklist
3

don't pass user input to innerHTML #42

Merged
r10s merged 4 commits from adb/issue-8 into master 2023年09月15日 12:20:11 +02:00

close #8

close #8
main.js Outdated
@ -120,3 +131,1 @@
viewBox="0 -4 32 32" width="20" height="20" fill="white" stroke="white" stroke-width="1">
<path d="M17 6H22V8H20V21C20 21.5523 19.5523 22 19 22H5C4.44772 22 4 21.5523 4 21V8H2V6H7V3C7 2.44772 7.44772 2 8 2H16C16.5523 2 17 2.44772 17 3V6ZM18 8H6V20H18V8ZM9 4V6H15V4H9Z"></path>
</svg></button>`;
const deleteIcon = fromHTML(
Author
Owner
Copy link

mmmh just realized the code is using tabs instead of space, causing annoyances at the time to review PRs, it is better if they are removed in a next PR, or we use a code formatter to make it easy to integrate new changes without disrupting the current code format convention adopted in the project

mmmh just realized the code is using tabs instead of space, causing annoyances at the time to review PRs, it is better if they are removed in a next PR, or we use a code formatter to make it easy to integrate new changes without disrupting the current code format convention adopted in the project
Owner
Copy link

yeah, @WofWca and me are also a bit annoyed by the tabs, did not change yet, but are planning to do so, somehow

if not too hard, maybe you can adapt your pr for now, at least the parts that are "inlined"

yeah, @WofWca and me are also a bit annoyed by the tabs, did not change yet, but are planning to do so, somehow if not too hard, maybe you can adapt your pr for now, at least the parts that are "inlined"
adbenitez marked this conversation as resolved
Owner
Copy link

nice, i am too tired to review this just now, however :)

nice, i am too tired to review this just now, however :)
Author
Owner
Copy link

I tried to use tabs, should be easier to compare now

I tried to use tabs, should be easier to compare now
r10s left a comment
Copy link

great, lgtm and also tested a bit

great, lgtm and also tested a bit
@ -123,0 +135,4 @@
const form = h(
'form', {id: item.guid + '-form', class: 'AppUpdate AppListItemForm'},
h('input', {class: 'AppListItemUpdateField AppListItemField', type: 'text', maxlength: 200, value: oldText, autofocus: ''}),
Owner
Copy link

i was wondering, if a boolean attribute, that is true by only its presence in a tag (like <input ... autofocus>) is really set by setElement('autofocus', '') where '' will evaluate to false - but indeed, this is the approach recommended by eg. mozilla: https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute

i was wondering, if a boolean attribute, that is true by only its presence in a tag (like `<input ... autofocus>`) is really set by `setElement('autofocus', '')` where `''` will evaluate to `false` - but indeed, this is the approach recommended by eg. mozilla: https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/checklist!42
Reference in a new issue
webxdc/checklist
No description provided.
Delete branch "adb/issue-8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?