webxdc/checklist
15
2
Fork
You've already forked checklist
3

add main menu #33

Merged
r10s merged 3 commits from add-menu into master 2023年09月14日 12:12:06 +02:00
Owner
Copy link

see commit messages for details.

i tried to mimics the existing coding style - without knowing the exact gist - however, i think it is good enough and easy enough to understand.

most important thing is the outcome for the user.

once this is merged, we also have a nice ground for further options, as import-file or paste-from-clipboard, cmp. #3

closes #28

see commit messages for details. i tried to mimics the existing coding style - without knowing the exact gist - however, i think it is good enough and easy enough to understand. most important thing is the outcome for the user. once this is merged, we also have a nice ground for further options, as import-file or paste-from-clipboard, cmp. #3 closes #28
r10s changed title from (削除) WIP: add main menu (削除ここまで) to add main menu 2023年09月13日 17:39:11 +02:00
index.html Outdated
@ -14,3 +14,1 @@
<!-- `contenteditable="plaintext-only"` would be more suitable IMO,
but is not well supported yet. -->
<h1 id="AppHeading" class="AppHeading" contenteditable="true" oninput="AppSaveTitleButton.style.display = ''">Checklist</h1>
<div id="MainMenu" onclick="AppBehaviour.ControlOpenMenu()">⋮<div id="MenuItems" class="hidden">
Owner
Copy link

This is not accessible. I usually use a <button> in such cases.

This is not accessible. I usually use a `<button>` in such cases.
Author
Owner
Copy link

i am sure, the whole menu can be done better.

not sure if nested buttons are allowed, therefore i avoided that for now. compared to other accessibility issues, this is a minor one anyways.

i am sure, the whole menu can be done better. not sure if nested buttons are allowed, therefore i avoided that for now. compared to other accessibility issues, this is a minor one anyways.
Owner
Copy link

Nested buttons are not allowed. In this case I would have made them adjacent to each other.

Nested buttons are not allowed. In this case I would have made them adjacent to each other.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/checklist!33
Reference in a new issue
webxdc/checklist
No description provided.
Delete branch "add-menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?