webxdc/checklist
15
2
Fork
You've already forked checklist
3

adapt project to vite #18

Closed
adbenitez wants to merge 1 commit from adb/use-vite into master
pull from: adb/use-vite
merge into: webxdc:master
webxdc:master
webxdc:all-updates
webxdc:fix-init-override
webxdc:adb/issue-8
webxdc:update-webxdc-js
webxdc:tweak-layout
webxdc:add-menu
webxdc:fix-title-linebreaks
webxdc:positive-icon
webxdc:update-icon
webxdc:pages

I also tried to improve the project layout

I also tried to improve the project layout
WofWca left a comment
Copy link

I can see there are also some small changes, like the removal of <title> from index.html and description from manifest.toml.

I can see there are also some small changes, like the removal of `<title>` from `index.html` and `description` from `manifest.toml`.
Author
Owner
Copy link

oh yarn it, other PRs got merged before merging this now there are conflicts, I recommend focus on merging this PR before any further changes since there are heavy changes

oh yarn it, other PRs got merged before merging this now there are conflicts, I recommend focus on merging this PR before any further changes since there are heavy changes
Author
Owner
Copy link

I can see there are also some small changes, like the removal of <title> from index.html and description from manifest.toml.

yes and that is quite intentional, title tag is discouraged in webxdc specs, it is unused by the implementations and should not be set since there is no point on it, and the description field in the manifest is also not standard and not needed

> I can see there are also some small changes, like the removal of `<title>` from `index.html` and `description` from `manifest.toml`. yes and that is quite intentional, title tag is discouraged in webxdc specs, it is unused by the implementations and should not be set since there is no point on it, and the description field in the manifest is also not standard and not needed

I will resolve the conflicts now.

I will resolve the conflicts now.
Author
Owner
Copy link

:( still conflicts ➡️💥⬅️

:( still conflicts ➡️💥⬅️
Author
Owner
Copy link

seems to work fine, feel free to merge!

seems to work fine, feel free to merge!

Merged as ad706b9e6b

Merged as ad706b9e6b8a1515a1078c732fa04be06a2eee6e
WofWca closed this pull request 2023年09月01日 12:51:36 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webxdc/checklist!18
Reference in a new issue
webxdc/checklist
No description provided.
Delete branch "adb/use-vite"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?