Game crashes after plugging in gamepad and racing in Free Roam #76

Ghost commented 2024年04月20日 10:43:21 +02:00

Steps to reproduce

1. Open the game
2. Selected "Free Roam" from menu
3. Plugged in my USB gamepad
4. Drive around
5. Press "Exit"

There is also a related crash from main menu, they share the exact same crash report. Here's how to reproduce that too:

1. Start game with gamepad (or connect later)
2. Press any gamepad btn (directional or otherwise)
3. Game crash

Logs

Thread 1 "wasted" received signal SIGSEGV, Segmentation fault.
0x000055555598003c in Camera::getType (this=0x0)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/graphics/camera.hpp:187
187	 CameraType getType() { return m_type; }
(gdb) backtrace
#0 0x000055555598003c in Camera::getType (this=0x0)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/graphics/camera.hpp:187
#1 0x0000555555b6509c in InputManager::input (this=0x5555578cff00, event=...)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/input/input_manager.cpp:944
#2 0x0000555555b63304 in InputManager::handleJoystick (this=0x5555578cff00, event=...)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/input/input_manager.cpp:198
#3 0x0000555555b63107 in handle_joystick (event=...)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/input/input_manager.cpp:166
#4 0x00005555560b5d91 in irr::CIrrDeviceSDL::run (this=0x55555772b030)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/lib/irrlicht/source/Irrlicht/CIrrDeviceSDL.cpp:934
#5 0x0000555555acda00 in GUIEngine::renderLoading (clearIcons=false, launching=true,
 update_tips=false)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/guiengine/engine.cpp:1538
#6 0x0000555555acdcc9 in GUIEngine::addLoadingIcon (icon=0x555558e0b680)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/guiengine/engine.cpp:1570
#7 0x0000555555c740e4 in initRest ()
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/main.cpp:1968
#8 0x0000555555c75201 in main (argc=1, argv=0x7fffffffdd28)
 at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/main.cpp:2264

Game version 6ca392de31

## Steps to reproduce 1. Open the game 2. Selected "Free Roam" from menu 3. Plugged in my USB gamepad 4. Drive around 5. Press "Exit" 6. There is also a related crash from main menu, they share the exact same crash report. Here's how to reproduce that too: 1. Start game with gamepad (or connect later) 2. Press any gamepad btn (directional or otherwise) 3. Game crash ## Logs ``` Thread 1 "wasted" received signal SIGSEGV, Segmentation fault. 0x000055555598003c in Camera::getType (this=0x0) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/graphics/camera.hpp:187 187 CameraType getType() { return m_type; } (gdb) backtrace #0 0x000055555598003c in Camera::getType (this=0x0) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/graphics/camera.hpp:187 #1 0x0000555555b6509c in InputManager::input (this=0x5555578cff00, event=...) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/input/input_manager.cpp:944 #2 0x0000555555b63304 in InputManager::handleJoystick (this=0x5555578cff00, event=...) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/input/input_manager.cpp:198 #3 0x0000555555b63107 in handle_joystick (event=...) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/input/input_manager.cpp:166 #4 0x00005555560b5d91 in irr::CIrrDeviceSDL::run (this=0x55555772b030) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/lib/irrlicht/source/Irrlicht/CIrrDeviceSDL.cpp:934 #5 0x0000555555acda00 in GUIEngine::renderLoading (clearIcons=false, launching=true, update_tips=false) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/guiengine/engine.cpp:1538 #6 0x0000555555acdcc9 in GUIEngine::addLoadingIcon (icon=0x555558e0b680) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/guiengine/engine.cpp:1570 #7 0x0000555555c740e4 in initRest () at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/main.cpp:1968 #8 0x0000555555c75201 in main (argc=1, argv=0x7fffffffdd28) at /home/spongy/.local/src/spongy-derby-fork/testing-branch/src/main.cpp:2264 ``` Game version 6ca392de31bd6d59aa38b219d8a1519d631b0060

Ghost commented 2024年04月20日 16:57:44 +02:00

Placed an assert at line 935 input_manager.cpp

EventPropagation InputManager::input(const SEvent& event)
{
assert(Camera::getActiveCamera();
}

This assertion fails in the mention circumstances. So this evidence leads me to believe its a simple bug related to memory addressed not being stored when its called.

I hope this helps.

Placed an assert at line 935 `input_manager.cpp` ``` EventPropagation InputManager::input(const SEvent& event) { assert(Camera::getActiveCamera(); } ``` This assertion fails in the mention circumstances. So this evidence leads me to believe its a simple bug related to memory addressed not being stored when its called. I hope this helps.

Ghost commented 2024年04月20日 21:04:18 +02:00

Your update (1c0afee59e) seems to have made a positive difference to my game. It stopped the previously mentioned problems occurring.

I'll keep an eye on the issue for the next couple of weeks. Thanks for your fix!

Your update (1c0afee59ee2663eefe9d0c6b664cdc8e524b956) seems to have made a positive difference to my game. It stopped the previously mentioned problems occurring. I'll keep an eye on the issue for the next couple of weeks. Thanks for your fix!

franzbonanza commented 2024年04月20日 21:59:51 +02:00

Thank you for finding the bug! Closing it for the moment

Thank you for finding the bug! Closing it for the moment