wastedgames/wasted-code
7
27
Fork
You've already forked wasted-code
5

[FEATURE] Separate FFA server class from client logic #48

Open
opened 2023年09月17日 20:41:30 +02:00 by franzbonanza · 6 comments

Properly separate server and client class for FFA class. Right now the server class is kinda a duplicate of the client one.

Properly separate server and client class for FFA class. Right now the server class is kinda a duplicate of the client one.
Author
Owner
Copy link

There are some issues for now that arised trying to clean the classes. CTF depends on FFA and some other methods from FFA server cannot be deleted entirely.

There are some issues for now that arised trying to clean the classes. CTF depends on FFA and some other methods from FFA server cannot be deleted entirely.
Author
Owner
Copy link

We need to remove the function "isRaceOver" from the client class. It's always false and it is unused. It is triggered in the server class already. Right now is never being called.

We need to remove the function "isRaceOver" from the client class. It's always false and it is unused. It is triggered in the server class already. Right now is never being called.

I would recommend a new class for server world is needed and the relevant methods that covers only the server use-cases should be ripped out of the World header file and added to this new class. Namely, isNetworkedGame and isRaceOver from the top of my head. FreeForAllServer should implement both FreeForAll and this new server world class.

I would recommend a new class for server world is needed and the relevant methods that covers only the server use-cases should be ripped out of the World header file and added to this new class. Namely, `isNetworkedGame` and `isRaceOver` from the top of my head. `FreeForAllServer` should implement both FreeForAll and this new server world class.
Author
Owner
Copy link

Removed setKartHpsPowerup and setKartHps unused methods from ffa client class c74d33cd69

Removed `setKartHpsPowerup` and `setKartHps` unused methods from ffa client class c74d33cd69
Author
Owner
Copy link

Removed method that prints message in ffa server class e02d59be5c

Removed method that prints message in ffa server class e02d59be5c
Author
Owner
Copy link

Removed unused code from ffa client class 7047fcb61e

Removed unused code from ffa client class 7047fcb61e
Sign in to join this conversation.
No Branch/Tag specified
main
dev
b_#215_fix_appimage_issues_on_some_distros
f_#220_remove_run_game_script_with_desktop_file
b_#221_garage_screen_does_not_resize_properly
f_#209_add_tooltip_to_menu_icon
b_#170_chat_messages_not_retained_when_modal_is_open
f_#164_make_explosion_pitch_random_clean
b_#211_rearlights_not_destroyed_after_carchange
f_#164_make_explosion_pitch_random
b_#217_modals_opened_on_top_of_screen_not_making_bg_darker
b_#214_kart_color_change_option_available_in_game_options
b_fps_bug
destorycarfix
b_#204_nitro_not_retained_upon_car_change
b_#203_fps_camera_randomly_unproperly_initialized
b_#101_radio_station_playback_start_briefly_music_from_0_when_seekeing
f_#151_rework_lean_for_cars
f_#178_warn_player_who_is_not_moving
f_#199_custom_suspension_max_force_and_stiffness
f_#198_add_car_offset_for_suspension_height
b_#197_gearchange_cooldown_not_properly_implemented
f_#147_rework_explosion
f_#161_create_garage_screen
release_0_7_8_onfoss
f_#158_make_simulated_engine_gears_follow_the_gears_contained_in_the_xml_cars_file
f_#183_blur_background_during_game_pause
f_#141_check_wayland_lib
f_#142_add_damage_counter_in_UI_during_online_matches
f_#22_punish_inactive_players
b_#143_fix_car_not_respawning_on_map_when_falling_off_in_tutorial_overworld
f_#139_add_random_color_picker_option
b_#113_enabling_music_in_options_play_menu_track
f_#108_improvement_of_car_bounce
f_#112_balance_classes
b_#110_reset_camera_triggers_skidmark
f_#97_radio_player
b_#96_fix_orbital_camera
b_#_92_car_change_broken
f_#87_show_red_text_when_player_is_eliminated
f_#84_turn_on_brakinglights_when_braking
f_#73_improved_game_testing
health_system
0.8.5-alpha
0.8.0-alpha
0.7.8-onfoss
0.7.5-alpha
0.7.0-alpha
0.6.0-alpha
0.5.0-alpha
0.4.0-alpha
0.3.0-alpha
0.2.0-alpha
0.1.0-alpha
Test-release
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
wastedgames/wasted-code#48
Reference in a new issue
wastedgames/wasted-code
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?