universish/Kvaesitso..Settings..Openner
1
0
Fork
You've already forked Kvaesitso..Settings..Openner
0

Add 8-bit width support to the binary clock #1649

Open
Druthyn wants to merge 2 commits from Druthyn/main into main
pull from: Druthyn/main
merge into: universish:main
universish:feature/settings-shortcut
universish:main
universish:crowdin
Druthyn commented 2025年10月11日 21:35:11 +02:00 (Migrated from github.com)
Copy link

Adds a toggle for the binary clock to display each value (hours, minutes, seconds) using 8 bits, instead of a mixture of 4, 5, and 6 bits, depending on the value, and whether 24-hour time is used.

Media (27)

  • The option is only available in Default mode, as it seemed antithetical to compacts aims.
  • Seconds remain optional

As an implementation note, I'm unsure if I needed to make the changes currently commented out in app/ui/src/main/java/de/mm20/launcher2/ui/launcher/widgets/clock/WatchFaceSelector.kt. I thought they were, but it seems to function fine without them.

Adds a toggle for the binary clock to display each value (hours, minutes, seconds) using 8 bits, instead of a mixture of 4, 5, and 6 bits, depending on the value, and whether 24-hour time is used. ![Media (27)](https://github.com/user-attachments/assets/6ed99d80-d9d5-4b14-8482-d3d703975aba) - The option is only available in Default mode, as it seemed antithetical to compacts aims. - Seconds remain optional As an implementation note, I'm unsure if I needed to make the changes currently commented out in `app/ui/src/main/java/de/mm20/launcher2/ui/launcher/widgets/clock/WatchFaceSelector.kt`. I thought they were, but it seems to function fine without them.
Druthyn commented 2026年01月03日 03:09:50 +01:00 (Migrated from github.com)
Copy link

@MM2-0 Heya, any feedback?

@MM2-0 Heya, any feedback?
This pull request has changes conflicting with the target branch.
  • app/ui/src/main/java/de/mm20/launcher2/ui/launcher/widgets/clock/ClockWidget.kt
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Druthyn/main:Druthyn/main
git switch Druthyn/main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff Druthyn/main
git switch Druthyn/main
git rebase main
git switch main
git merge --ff-only Druthyn/main
git switch Druthyn/main
git rebase main
git switch main
git merge --no-ff Druthyn/main
git switch main
git merge --squash Druthyn/main
git switch main
git merge --ff-only Druthyn/main
git switch main
git merge Druthyn/main
git push origin main
Sign in to join this conversation.
No reviewers
Labels
Clear labels
android:10
Affects Android 10
android:11
Affects Android 11
android:12
Affects Android 12
android:13
Affects Android 13
android:14
Affects Android 14
android:15
Affects Android 15
android:16
Affects Android 16
android:8
Affects Android 8
android:9
Affects Android 9
bug
Something isn't working
cant reproduce
Issue can't be reproduced on any of the developer's devices or emulators
crash report
A crash report from the launcher
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
intended behavior
Issue does not require further action
more information needed
Issue doesn't provide enough useful information the be worked on
topic:app-grid
topic:backup-restore
topic:badges
topic:calendar-widget
topic:clock-widget
topic:file-search
topic:icons
topic:media-widget
topic:search
topic:shortcuts
topic:weather-widget
topic:widgets
topic:work-profile
vendor:asus
Affects Asus devices
vendor:cubot
Affects Cubot devices
vendor:google
Affects Google devices
vendor:grapheneos
Affects devices running GrapheneOS
vendor:hmd
Affects HMD/Nokia devices
vendor:honor
Affects Honor devices
vendor:huawei
Affects Huawei devices
vendor:infinix
Affects Infinix devices
vendor:lenovo
Affects Lenovo devices
vendor:lineageos
Affects devices running LineageOS
vendor:motorola
Affects Motorola devices
vendor:nothing
Affects Nothing devices
vendor:nubia
Affects Nubia devices
vendor:oneplus
Affects OnePlus devices
vendor:oppo
Affects Oppo/Realme devices
vendor:samsung
Affects Samsung devices
vendor:tecno
Affects Tecno devices
vendor:vivo
Affects Vivo devices
vendor:xiaomi
Affects Xiaomi/Redmi/Poco devices
wontfix
This will not be worked on
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
universish/Kvaesitso..Settings..Openner!1649
Reference in a new issue
universish/Kvaesitso..Settings..Openner
No description provided.
Delete branch "Druthyn/main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?