Filters & PDF Reports #387

ybb40cxt commented 2024年07月22日 16:21:50 +02:00

When applying a Filter to an Active Tab and opening the PDF Report, the Statistics summary calculations for the Total seem awry?

• Without a Filter the Statistics Total column seems correct.
• For an "apples to apples comparison" with a 1 Month filter the Total column does not equal the 1 Month column.*
• The 1 Year column always seems correct. Not filter influenced?
• The 1 Month column always seems correct, Not filter influenced?

*My assumption/suspicion would be the "Total" calculation on the PDF Report should be based on the Total filter criteria (but currently is not) or Total should always = Total (all data) in the summary even if a Filter has been applied to the other pages of the report?

I tested the Filters and PDF Reports on the Weight and Blood Pressure tabs and it didn't seem to be isolated to a single Tab. I also noted that the formatting of the Statistics totals on the PDF Reports is inconsistent:

Weight: Total, 1 Year, 1 Month vs BP: 1 Month, 1 Year, Total

MediLog Version 2.7.3 build 5447 on Android 14.

When applying a Filter to an Active Tab and opening the PDF Report, the Statistics summary calculations for the Total seem awry? - Without a Filter the Statistics Total column seems correct. - For an "apples to apples comparison" with a 1 Month filter the Total column does not equal the 1 Month column.* - The 1 Year column always seems correct. Not filter influenced? - The 1 Month column always seems correct, Not filter influenced? _*My assumption/suspicion would be the "Total" calculation on the PDF Report should be based on the Total filter criteria (but currently is not) or Total should always = Total (all data) in the summary even if a Filter has been applied to the other pages of the report?_ I tested the Filters and PDF Reports on the Weight and Blood Pressure tabs and it didn't seem to be isolated to a single Tab. I also noted that the formatting of the Statistics totals on the PDF Reports is inconsistent: Weight: Total, 1 Year, 1 Month vs BP: 1 Month, 1 Year, Total **MediLog Version 2.7.3 build 5447 on Android 14.**

toz commented 2024年07月23日 19:50:31 +02:00

Thanks for reporting @ja7833, I completely redid the info screen in v3, it now shows filtered and database in separate sections, and after briefly checking just now I think the data shown is correct.
The PDF report is still v2.7.x style and should get the same revamp. I will schedule this for v3.1.

My priority right now is to get v3 out of the door to get away from dealing with two code bases. Hopefully we can get to the bottom of the crash you reported separately as quickly as possible as this is the last remaining showstopper for me.

Thanks for reporting @ja7833, I completely redid the info screen in v3, it now shows filtered and database in separate sections, and after briefly checking just now I think the data shown is correct. The PDF report is still v2.7.x style and should get the same revamp. I will schedule this for v3.1. My priority right now is to get v3 out of the door to get away from dealing with two code bases. Hopefully we can get to the bottom of the crash you reported separately as quickly as possible as this is the last remaining showstopper for me.

ybb40cxt commented 2024年07月23日 21:26:42 +02:00

I completely redid the info screen in v3... I think the data shown is correct

The data displayed on-screen for RC2 seems okay.

My priority right now is to get v3 out of the door to get away from dealing with two code bases.

I just installed RC2 and restored my data, no crash at launch.

>I completely redid the info screen in v3... I think the data shown is correct The data displayed on-screen for RC2 seems okay. >My priority right now is to get v3 out of the door to get away from dealing with two code bases. I just installed RC2 and restored my data, no crash at launch.

toz commented 2024年07月24日 09:39:55 +02:00

This is really good to read!

This is really good to read!

ybb40cxt commented 2024年10月31日 16:31:43 +01:00

With several 3.0x releases completed and PDF reports now on the 3.1 roadmap, I took a new look at my original comment from 2.7.3.

I believe consistency is what I was thinking. With the same data displayed in Tab Info being included in the PDF Report Statistics.

e.g. in 3.0.7

Blood Pressure info tab displays:

Measurements; 1 Month; 1 Year; Total
Systolic min
Systolic max
Systolic avg.
Diastolic min
Diastolic max
Diastolic avg.
Pulse min
Pulse max
Pulse avg.

Blood Pressure report displays:

Measurements; 1 Month; 1 Year; Total
Systolic min
Systolic max
?
Diastolic min
Diastolic max
?
Pulse min
Pulse max
?

The 1 Month numbers match between the Info Tab and the PDF Report. But, the PDF Report 1 Year and Total equal the PDF Report 1 Month numbers (assume error) which then do not match the Info Tab 1 Year and Totals (assume correct).

NOT UNDERSTANDING how calculations are done in the background my suggestion would be to disregard any Filter option a end-user has set for their graphs and for both the Tab Info and PDF Report Statistics default to: a rolling 30 days; a rolling 365 days; and TOTAL (or any other timeframe you think most appropriate: 7 days; 30 days; TOTAL). With all Info Tabs and PDF Reports being as similar as possible i.e. always sorted LESS, MORE, TOTAL.

With several 3.0x releases completed and PDF reports now on the 3.1 roadmap, I took a new look at my original comment from 2.7.3. I believe consistency is what I was thinking. With the same data displayed in **Tab Info** being included in the **PDF Report Statistics**. e.g. in 3.0.7 **Blood Pressure info tab displays:** Measurements; 1 Month; 1 Year; Total Systolic min Systolic max _Systolic avg._ Diastolic min Diastolic max _Diastolic avg._ Pulse min Pulse max _Pulse avg._ **Blood Pressure report displays:** Measurements; 1 Month; 1 Year; Total Systolic min Systolic max ? Diastolic min Diastolic max ? Pulse min Pulse max ? The 1 Month numbers match between the Info Tab and the PDF Report. But, the PDF Report 1 Year and Total equal the PDF Report 1 Month numbers (assume error) which then do not match the Info Tab 1 Year and Totals (assume correct). _NOT UNDERSTANDING_ how calculations are done in the background my suggestion would be to disregard any Filter option a end-user has set for their graphs and for both the Tab Info and PDF Report Statistics default to: a rolling 30 days; a rolling 365 days; and TOTAL (or any other timeframe you think most appropriate: 7 days; 30 days; TOTAL). With all Info Tabs and PDF Reports being as similar as possible i.e. always sorted LESS, MORE, TOTAL.

toz commented 2024年10月31日 17:42:42 +01:00

Great, I startet working on this so you testing helps a lot!

Great, I startet working on this so you testing helps a lot!

toz commented 2024年11月07日 18:00:56 +01:00

BloodPressure Info and PDF should be consistent now. It's the same code which runs for both.
I'll likely do a beta of v3.1.0 over the weekend.

BloodPressure Info and PDF should be consistent now. It's the same code which runs for both. I'll likely do a beta of v3.1.0 over the weekend.