1
2
Fork
You've already forked itemframes
2

fix itemframes showing the wrong items #4

Closed
tour-ist wants to merge 2 commits from (deleted):master into master
pull from: (deleted):master
merge into: tenplus1:master
tenplus1:master
First-time contributor
Copy link

when creating a new itemframe entity, the var tmp is used to transfer information about texture and node. If the entity creation fails, either because minetest.add_entity fails or because there is another itemframe entity on this pos already, tmp is not cleared. This means that the next itemframe entity loading will read from tmp and thus will use the wrong item. It will even keep the wrong texture during reload because the texture information is stored in the entities metadata...

when creating a new itemframe entity, the var `tmp` is used to transfer information about texture and node. If the entity creation fails, either because `minetest.add_entity` fails or because there is another itemframe entity on this pos already, `tmp` is not cleared. This means that the next itemframe entity loading will read from `tmp` and thus will use the wrong item. It will even keep the wrong texture during reload because the texture information is stored in the entities metadata...

Thanks for the bug find, updated :)

Thanks for the bug find, updated :)
tenplus1 closed this pull request 2024年05月07日 13:22:48 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tenplus1/itemframes!4
Reference in a new issue
tenplus1/itemframes
No description provided.
Delete branch "(deleted):master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?