remove duplicate entities again #3

fluxionary commented 2024年04月11日 01:10:06 +02:00

with your most recent update (8f39564306), you've again made the entities static_save, which results in them duplicating the entity if the frame node loads before the entity is loaded.

this PR checks to see whether there's already an entity present both when the node loads, and also when the entity loads, and removes all duplicates found at either time.

with your most recent update (https://codeberg.org/tenplus1/itemframes/commit/8f39564306e041996815e40281070a0ebf0576e3), you've again made the entities static_save, which results in them duplicating the entity if the frame node loads before the entity is loaded. this PR checks to see whether there's already an entity present *both* when the node loads, and also when the entity loads, and removes all duplicates found at either time.

tenplus1 commented 2024年04月11日 09:16:24 +02:00

I had to revert the static_save as entities were always appearing as "air" and not updating until a fix was applied. Thank you for the fix :)

I had to revert the static_save as entities were always appearing as "air" and not updating until a fix was applied. Thank you for the fix :)