Is ground content #4

SwissalpS commented 2024年02月29日 13:49:58 +01:00

see https://github.com/pandorabox-io/pandorabox.io/issues/836

Seeds and growing plants are user generated.
The grown plants that are passed to mapgen as decorations could arguably
be considered ground content - I opted not to in this commit.
Jack-o-lantern, scarecrow and similar nodes are of course also not ground content.

see https://github.com/pandorabox-io/pandorabox.io/issues/836 Seeds and growing plants are user generated. The grown plants that are passed to mapgen as decorations could arguably be considered ground content - I opted not to in this commit. Jack-o-lantern, scarecrow and similar nodes are of course also not ground content.

tenplus1 commented 2024年02月29日 17:42:22 +01:00

Changes made :)

I gotta ask, what's up with the is_ground_content changes ? Am I missing something ?

Changes made :) I gotta ask, what's up with the is_ground_content changes ? Am I missing something ?

SwissalpS commented 2024年03月04日 01:34:30 +01:00

for most games and players it doesn't really matter. In combination with mods that can move nodes around, it can start to show effect. The chances are slim, but players have lost their builds when using [jumpdrive] to jump them near mapblocks that aren't generated yet.

It can also have effect on servers where they delete/regen areas, the neighbouring areas can be afected by mapgen's cave algorythim.

for most games and players it doesn't really matter. In combination with mods that can move nodes around, it can start to show effect. The chances are slim, but players have lost their builds when using [jumpdrive] to jump them near mapblocks that aren't generated yet. It can also have effect on servers where they delete/regen areas, the neighbouring areas can be afected by mapgen's cave algorythim.

tenplus1 commented 2024年03月04日 07:36:19 +01:00

Ahh okie, I didn't realise not having it set would could issue :) Thanks for letting me know.

Ahh okie, I didn't realise not having it set would could issue :) Thanks for letting me know.