3
9
Fork
You've already forked enum-map
8

Add optional support for borsh serialisation #113

Merged
sugar700 merged 1 commit from Fuuzetsu/enum-map:borsh into master 2023年12月01日 09:06:49 +01:00
Contributor
Copy link
No description provided.
sugar700 left a comment
Copy link

Looks great 👍. Just mentioning some small changes I would like to see. Also, please update rust-version in Cargo.toml to 1.66, as well as the Rust version in .woodpecker/test.yml so that tests would pass.

Looks great :+1:. Just mentioning some small changes I would like to see. Also, please update `rust-version` in `Cargo.toml` to 1.66, as well as the Rust version in `.woodpecker/test.yml` so that tests would pass.
CHANGELOG.md Outdated
@ -18,6 +18,8 @@ SPDX-License-Identifier: MIT OR Apache-2.0
- Updated author name.
- Added optional support for `borsh` serialisation.
Owner
Copy link

Please create "Version 3.0.0-beta.3" header for this change.

Please create "Version 3.0.0-beta.3" header for this change.
Fuuzetsu marked this conversation as resolved
@ -22,6 +22,7 @@ maintenance = { status = "passively-maintained" }
[dependencies]
arbitrary = { version = "1.0.0", optional = true }
borsh = { version = "1.2", default-features = false, optional = true }
Owner
Copy link

Please specify version as 1.2.0. See https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277?u=xfix.

Please specify version as `1.2.0`. See https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277?u=xfix.
Fuuzetsu marked this conversation as resolved
Author
Contributor
Copy link

I've made the suggested changes, I think.

I've made the suggested changes, I think.
sugar700 left a comment
Copy link

Looks fine otherwise.

Looks fine otherwise.
CHANGELOG.md Outdated
@ -12,6 +12,16 @@ SPDX-License-Identifier: MIT OR Apache-2.0
- Reduced RAM usage and improved compilation times when using `derive(Enum)`
for large enums with `overflow-checks` enabled.
# Version 3.0.0-beta.3
Owner
Copy link

Put this heading above "Version 2.7.3" heading (rebase so that there will be "Version 2.7.3" heading).

Put this heading above "Version 2.7.3" heading (rebase so that there will be "Version 2.7.3" heading).
Fuuzetsu marked this conversation as resolved
Fuuzetsu force-pushed borsh from e7b55a9743
All checks were successful
ci/woodpecker/pr/reuse Pipeline was successful
ci/woodpecker/pr/rustfmt Pipeline was successful
ci/woodpecker/pr/test/1 Pipeline was successful
ci/woodpecker/pr/miri Pipeline was successful
ci/woodpecker/pr/test/2 Pipeline was successful
to 4b8fade3e4
All checks were successful
ci/woodpecker/pr/rustfmt Pipeline was successful
ci/woodpecker/pr/reuse Pipeline was successful
ci/woodpecker/pr/test/1 Pipeline was successful
ci/woodpecker/pr/miri Pipeline was successful
ci/woodpecker/pr/test/2 Pipeline was successful
2023年11月29日 00:51:46 +01:00 Compare
CHANGELOG.md Outdated
@ -20,6 +26,10 @@ SPDX-License-Identifier: MIT OR Apache-2.0
- Reduced RAM usage and improved compilation times when using `derive(Enum)`
for large enums with `overflow-checks` enabled.
## Incompatible changes
Owner
Copy link

The incompatible changes should be with rest of the changes in 3.0.0-beta.3.

The incompatible changes should be with rest of the changes in 3.0.0-beta.3.
Fuuzetsu marked this conversation as resolved
Fuuzetsu force-pushed borsh from 4b8fade3e4
All checks were successful
ci/woodpecker/pr/rustfmt Pipeline was successful
ci/woodpecker/pr/reuse Pipeline was successful
ci/woodpecker/pr/test/1 Pipeline was successful
ci/woodpecker/pr/miri Pipeline was successful
ci/woodpecker/pr/test/2 Pipeline was successful
to 555890635c
All checks were successful
ci/woodpecker/pr/reuse Pipeline was successful
ci/woodpecker/pr/rustfmt Pipeline was successful
ci/woodpecker/pr/test/1 Pipeline was successful
ci/woodpecker/pr/miri Pipeline was successful
ci/woodpecker/pr/test/2 Pipeline was successful
2023年12月01日 00:33:18 +01:00 Compare

Thank you for your contribution 😀. I will release this later on today.

Thank you for your contribution 😀. I will release this later on today.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sugar700/enum-map!113
Reference in a new issue
sugar700/enum-map
No description provided.
Delete branch "Fuuzetsu/enum-map:borsh"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?