3
16
Fork
You've already forked lichen
1

#24 Use file's type, not image for resizing #25

Merged
stringbone merged 2 commits from image into master 2024年01月16日 17:30:32 +01:00

I couldn't find anything regarding type on an image element, but realized that the MIME type was being checked on file. So mapped that over, which matches all the other API's.

Tested using JPG and PNG, the two supported file types.

I couldn't find anything regarding `type` on an `image` element, but realized that the MIME type was being checked on `file`. So mapped that over, which matches all the other API's. Tested using JPG and PNG, the two supported file types.
There is a `type` attribute in the image resizing that doesn't show up
after uploading an image. I can't find it on MDN's `HTMLImageElement`
spec, or any historical reference to it online. In all places that it is
used, it is optional. In my testing, I found removing it did not affect
the images I uploaded; tested with PNG and JPG, which are the two types
it supports anyway.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
stringbone/lichen!25
Reference in a new issue
stringbone/lichen
No description provided.
Delete branch "image"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?