3
16
Fork
You've already forked lichen
1

#7 Add type guards, error boundaries, and remove some globals #16

Merged
stringbone merged 5 commits from typing into master 2024年01月16日 03:59:13 +01:00
  • Add type guard abstractions for querySelector and get by ID
  • Add error boundaries for if elements don't exist or are not what is expected
  • Remove some globals through colocation or dependency injection

The typing work was done using the VSCode compiler.

TODO:

  • Test all added/modified functionality
    • iframe rendering properly on change
    • initializing file tree on load
    • navigating correctly to url on creating a new page
    • warning window styling when using link on rendered page
    • resizing a large image on upload (saving a blob promise)
  • Add tag/changeset for this work as a patch
* Add type guard abstractions for querySelector and get by ID * Add error boundaries for if elements don't exist or are not what is expected * Remove some globals through colocation or dependency injection The typing work was done using the VSCode compiler. TODO: * Test all added/modified functionality * [x] iframe rendering properly on change * [x] initializing file tree on load * [x] navigating correctly to url on creating a new page * [x] warning window styling when using link on rendered page * [x] resizing a large image on upload (saving a blob promise) * Add tag/changeset for this work as a patch
stringbone changed title from (削除) Add type guards, error boundaries, and remove some globals (削除ここまで) to #7 Add type guards, error boundaries, and remove some globals 2024年01月16日 03:45:54 +01:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
stringbone/lichen!16
Reference in a new issue
stringbone/lichen
No description provided.
Delete branch "typing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?