No description provided.
config.refactor #1
Open
bitnoise
wants to merge 6 commits from
config.refactor into main
pull from: config.refactor
merge into: stealth:main
stealth:main
stealth:generic
stealth:auth
bitnoise
commented 2024年12月06日 13:30:41 +01:00
bitnoise
added 3 commits 2024年12月06日 13:30:42 +01:00
Rename struct types and members for the alertmanager and simplepush endpoints to receiver and sender endpoints, respectively. Currently the only viable receiver is alertmanager, and the only viable sender is simplepush, but this change is the first in paving the way towards making the endpoints more generic and allowing for other alerting combinations of receiver and sender.
This is a major refactor of the code that queries and sets configuration parameters. Functions were simplified and separated into files that match their purpose. Rather than manually code various parameters and their handling (setting of defaults, CLI flag options, etc.), custom tags were implemented for the Config struct members. The options and their settings are now all parsed from a single, unified interface (the Config struct itself and its tags) so there is easier maintainability going forward.
Update the sample config file to reflect the changes in generalized endpoints, where each endpoint is either a receiver or sender, with default types for each (alertmanager for receiver and simplepush for sender).
bitnoise
requested review from stealth 2024年12月06日 13:52:40 +01:00
bitnoise
self-assigned this 2024年12月06日 13:52:52 +01:00
bitnoise
removed their assignment 2024年12月06日 13:53:05 +01:00
bitnoise
added 1 commit 2024年12月06日 18:33:04 +01:00
Align the README.md config descriptions with the new receiver/sender changes to the config handling.
bitnoise
added 2 commits 2024年12月06日 20:18:15 +01:00
Correct the environment variables and flags from alertmanager or simplepush to receiver or sender, respectively.
Rename all config "pass" variable/value instances to "password".
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.git fetch -u origin config.refactor:config.refactor
git switch config.refactor
Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.
git switch main
git merge --no-ff config.refactor
git switch config.refactor
git rebase main
git switch main
git merge --ff-only config.refactor
git switch config.refactor
git rebase main
git switch main
git merge --no-ff config.refactor
git switch main
git merge --squash config.refactor
git switch main
git merge --ff-only config.refactor
git switch main
git merge config.refactor
git push origin main
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
stealth/alertpush!1
Loading...
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "config.refactor"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?