refactor(ezo_types): remove dead/legacy callback plumbing #4

stackdrift commented 2026年05月31日 13:28:02 +02:00

Summary

Legacy / dead-code refactor for ezo_types. Stacked on #3 — based on feat/migrate-ezo-types and targets that branch, so this diff is only the cleanup (retarget to main once #3 merges).

• Removes five CallbackManagers + their add_*_callback methods — cell_constant, temp_scale, datalogger, temperature_change, extended_scale — that were declared and mostly fired but never subscribed by anything. They're relics of an earlier callback-based design, superseded by direct entity pointers (cell_constant_select_, tds_conversion_factor_number_), direct command methods (set_datalogger / set_extended_scale / ...), and the RT,<temp> compensated read.
• Keeps the load-bearing path: RTDSensor::check_temperature_change_ still maintains last_known_temperature_ (read by send_compensated_read_ for RT temp comp), and all parse_*_response_ logging is unchanged.

Test plan

• ./docker/esphome compile configs/test-ezo-types.yaml — green.
• No behaviour change (the .call()s fired into empty managers). OTA'd to the Atlas hydro monitor and verified: pH/EC/RTD/ORP, EC/TDS, and temperature compensation all read normally.

## Summary Legacy / dead-code refactor for `ezo_types`. **Stacked on #3** — based on `feat/migrate-ezo-types` and targets that branch, so this diff is only the cleanup (retarget to `main` once #3 merges). - Removes five `CallbackManager`s + their `add_*_callback` methods — `cell_constant`, `temp_scale`, `datalogger`, `temperature_change`, `extended_scale` — that were declared and mostly fired but **never subscribed** by anything. They're relics of an earlier callback-based design, superseded by direct entity pointers (`cell_constant_select_`, `tds_conversion_factor_number_`), direct command methods (`set_datalogger` / `set_extended_scale` / ...), and the `RT,<temp>` compensated read. - Keeps the load-bearing path: `RTDSensor::check_temperature_change_` still maintains `last_known_temperature_` (read by `send_compensated_read_` for RT temp comp), and all `parse_*_response_` logging is unchanged. ## Test plan - `./docker/esphome compile configs/test-ezo-types.yaml` — green. - No behaviour change (the `.call()`s fired into empty managers). OTA'd to the Atlas hydro monitor and verified: pH/EC/RTD/ORP, EC/TDS, and temperature compensation all read normally.