5
42
Fork
You've already forked inxi
2

Correct shebang #99

Closed
Vascom wants to merge 579 commits from patch-1 into master
pull from: patch-1
merge into: smxi:master
smxi:master
smxi:two
smxi:one
Vascom commented 2016年11月22日 09:08:37 +01:00 (Migrated from github.com)
Copy link
Please see issue https://github.com/smxi/inxi/issues/98
Mikaela commented 2016年11月22日 12:28:28 +01:00 (Migrated from github.com)
Copy link

In my opinion Fedora should patch inxi downstream instead of breaking projects for other distributions/operating systems.

In my opinion Fedora should patch inxi downstream instead of breaking projects for other distributions/operating systems.
Vascom commented 2016年11月22日 12:43:06 +01:00 (Migrated from github.com)
Copy link

I am know that use of /usr/bin/env has some advantages and disadvantages. I think it should be changed to good linux-style.

I am know that use of /usr/bin/env has some advantages and disadvantages. I think it should be changed to good linux-style.
kyrias commented 2016年11月22日 14:07:14 +01:00 (Migrated from github.com)
Copy link

Good style is making it as portable as possible, not changing it to suit one specific Linux distribution.

Good style is making it as portable as possible, not changing it to suit one specific Linux distribution.
Vascom commented 2016年11月22日 19:43:36 +01:00 (Migrated from github.com)
Copy link

OK. I already correct it in Fedora spec file. Report to you about it was my debt.

OK. I already correct it in Fedora spec file. Report to you about it was my debt.
smxi commented 2016年11月22日 19:48:55 +01:00 (Migrated from github.com)
Copy link

Vascom, again, as with issue 98, you need to learn about other non fedora operating systems, inxi runs on most BSDs, heck, it will even start on OSX, though it won't do much in that crippled OS, and the entire purpose of the cross platform method is to be cross platform. Also, of course, it future proofs inxi, against any possible changes to the bash path, etc. Any distro can place bash anywhere they want, and as long as they have env, it will be found without issue. This is in fact exactly why I changed that, because I test changes routinely on a FreeBSD box.

/usr/bin/env has as far as I know no disadvantages that are real or substantial, and allow all platforms to work as expected, unlike the fedora only method preferred. Since it's cross platform, it's obviously the superior method, not a bug or defect.

This seems symptomatic of a certain redhat corporate cultural blindness to all things non rpm or redhat based, and this isn't the only example I could mention, but I'll leave it at that.

Vascom, again, as with issue 98, you need to learn about other non fedora operating systems, inxi runs on most BSDs, heck, it will even start on OSX, though it won't do much in that crippled OS, and the entire purpose of the cross platform method is to be cross platform. Also, of course, it future proofs inxi, against any possible changes to the bash path, etc. Any distro can place bash anywhere they want, and as long as they have env, it will be found without issue. This is in fact exactly why I changed that, because I test changes routinely on a FreeBSD box. /usr/bin/env has as far as I know no disadvantages that are real or substantial, and allow all platforms to work as expected, unlike the fedora only method preferred. Since it's cross platform, it's obviously the superior method, not a bug or defect. This seems symptomatic of a certain redhat corporate cultural blindness to all things non rpm or redhat based, and this isn't the only example I could mention, but I'll leave it at that.
Vascom commented 2016年11月22日 19:53:37 +01:00 (Migrated from github.com)
Copy link

It's stupid to take care of other operating systems and distributions being maintainer of Fedora. I acted according to the rules - send a bug report and patch upstream. Your right it does not take. Nor any complaints I have.

It's stupid to take care of other operating systems and distributions being maintainer of Fedora. I acted according to the rules - send a bug report and patch upstream. Your right it does not take. Nor any complaints I have.
smxi commented 2016年11月22日 19:56:10 +01:00 (Migrated from github.com)
Copy link

"It's stupid to take care of other operating systems and distributions being maintainer of Fedora."

Ummm, no, that's completely wrong, but as I indicated, I've seen this problem in redhat/fedora for a few years now, being unaware of external realities. Personally I'd consider that a bug to be resolved internally in the project, because the more one understands other systems, the better one tends to be oneself. if you'd like to see the counter example to that, look at for example microsoft or apple, who also follow the corporate concept you are pointing to, being unaware of all external options. Debian, for example, is extremely aware of other options.

However, don't take this wrong, while of course I won't sabotage or break inxi in order to follow a technically wrong request, I am always happy to add or improve inxi with specific requirements that help end users, or that make inxi better, more flexible, accurate, etc.

"It's stupid to take care of other operating systems and distributions being maintainer of Fedora." Ummm, no, that's completely wrong, but as I indicated, I've seen this problem in redhat/fedora for a few years now, being unaware of external realities. Personally I'd consider that a bug to be resolved internally in the project, because the more one understands other systems, the better one tends to be oneself. if you'd like to see the counter example to that, look at for example microsoft or apple, who also follow the corporate concept you are pointing to, being unaware of all external options. Debian, for example, is extremely aware of other options. However, don't take this wrong, while of course I won't sabotage or break inxi in order to follow a technically wrong request, I am always happy to add or improve inxi with specific requirements that help end users, or that make inxi better, more flexible, accurate, etc.
Vascom commented 2016年11月22日 20:02:52 +01:00 (Migrated from github.com)
Copy link

It is not problem of Fedora, but recommendation.
Also about all my changes to inxi package I should inform you so it will not surprise. For example if someone report about this changes (or make bugreport) here.

And thank you for good tool.

It is not problem of Fedora, but recommendation. Also about all my changes to inxi package I should inform you so it will not surprise. For example if someone report about this changes (or make bugreport) here. And thank you for good tool.
smxi commented 2016年11月22日 20:04:51 +01:00 (Migrated from github.com)
Copy link

If your package works on redhat/fedora, then there would be no issues to report, and since changing shebang on a fedora only package would impact only redhat/fedora, and couldn't possibly fail, that's fine. If you made an actual substantive change it would be good to know about, though I've found I can usually add flags that allow features to be enabled or disabled so maintainers don't have to patch stuff every release.

If I were fedora I'd remove such non cross platform requirements from the rpmlint recommendations however, there's a LOT Of cross platform tools out there, and no reason to create obstacles for fedora package maintainers.

If your package works on redhat/fedora, then there would be no issues to report, and since changing shebang on a fedora only package would impact only redhat/fedora, and couldn't possibly fail, that's fine. If you made an actual substantive change it would be good to know about, though I've found I can usually add flags that allow features to be enabled or disabled so maintainers don't have to patch stuff every release. If I were fedora I'd remove such non cross platform requirements from the rpmlint recommendations however, there's a LOT Of cross platform tools out there, and no reason to create obstacles for fedora package maintainers.
Vascom commented 2016年11月22日 20:07:44 +01:00 (Migrated from github.com)
Copy link

OK.
What about remove execute bit from inxi.changelog and README.txt files?

OK. What about remove execute bit from inxi.changelog and README.txt files?
smxi commented 2016年11月22日 20:08:26 +01:00 (Migrated from github.com)
Copy link

the execute bit? is that there, that would be a good example of something that's correct to fix, I wasn't even aware of that.

the execute bit? is that there, that would be a good example of something that's correct to fix, I wasn't even aware of that.
kyrias commented 2016年11月22日 20:11:29 +01:00 (Migrated from github.com)
Copy link

Yeah, the changelog, README, and manpage all have the exec bit set.

Yeah, the changelog, README, and manpage all have the exec bit set.
smxi commented 2016年11月22日 20:15:07 +01:00 (Migrated from github.com)
Copy link

those are now corrected.

those are now corrected.
Vascom commented 2016年11月23日 08:57:37 +01:00 (Migrated from github.com)
Copy link

inxi.changelog is still has exec bit.

inxi.changelog is still has exec bit.
smxi commented 2016年11月23日 10:00:24 +01:00 (Migrated from github.com)
Copy link

so it does, as well as inxi.1, for some reason cp did not copy the corrected permissions, that's now fixed, or should be.

so it does, as well as inxi.1, for some reason cp did not copy the corrected permissions, that's now fixed, or should be.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Android
Ansible-Chef-Motd
related to running inxi inside of these tools
Apple-output-error-fixes-only
OSX is not supported beyond fixing Perl output errors.
ARM-CPU
BSD
Bug-Reproduced
BUG!
Character-encoding-issue
Chuckler
Brings a smile...
Close-If-No-Response
Closed-No-Response
Once a user fails to respond, within a few weeks, replace close if no response label with this one
Completed
Cygwin
yep, running on windows!!
Defect
Desktop-ID
Duplicate
Enhancement
Feature-not-a-bug
The issue is about an inxi feature that is intended, and is not a bug
Feature-request-exists
A feature request issue for something inxi already supports
Fixed
Flatpak-Snap-Appimage
FreeBSD-closed-no-data-supplied
Tired of having to get Linux users to do FreeBSD's work for them, no data, no help!
Garbage-Data
Google-Code-Issue
Great-Tip!
Help Wanted
HTML-Output
related to adding html output switch
Inadequate-Data-Source
Interesting-problem
Not necessarily related to inxi but still interesting.
Intermittent-issue
Issue comes and goes, and is not inxi related, though inxi exposes it when it happens
Invalid
Invalid-Leave-Visible
JSON-XML-export
Legacy Issue - Non Current inxi
Legacy Issue - Pre v 3.0
Locales
non C locales support
Microsoft WSL
MIPS-CPU
Mips, Loongson
Not-Currently-Possible
Ongoing-Updates
OSX
Outside-Of-Program-Scope
Oversight
Forgot to add in data type in one area
Packaging
packaging issues belong to the distro making the package. With one exception: TinyCore.
Patch
PPC
Priority-High
Priority-Low
Priority-Medium
Priority-None
Question
Required-Debugger-Data-Ignored
The poster failed to supply the required debugger data, and so the issue cannot be resolved.
Required-Work-Not-Done
If one of the Required labels was applied, and the issue poster did not do that work, and I did, keep this as a reminder.
Requires-Code
This issue requires the person making the request supply the code needed to resolve the issue.
Requires-Debugger-Data
This issue poster must supply the requested debugger data, it cannot be resolved without it.
Requires-Docs
This issue requires that the person requesting it supply the related documentation data and files.
Requires-Research
This issue requires that the poster do the research needed to understand and complete the issue. Research is easily 95% of any task in inxi.
Review
RTFM-(or -h)
Yes, an issue cased by not reading anything.
SSH-Access-Not-Given
SSH-Required
no support without SSH access, non trivial system issue.
Task
Waiting-Fix-Confirm
Wayland
anything where wayland seems to be the cause
Windows
No, really, people have asked!
Won't-Fix
ZFS
ZFS fs specific issues
No labels
Android
Ansible-Chef-Motd
Apple-output-error-fixes-only
ARM-CPU
BSD
Bug-Reproduced
BUG!
Character-encoding-issue
Chuckler
Close-If-No-Response
Closed-No-Response
Completed
Cygwin
Defect
Desktop-ID
Duplicate
Enhancement
Feature-not-a-bug
Feature-request-exists
Fixed
Flatpak-Snap-Appimage
FreeBSD-closed-no-data-supplied
Garbage-Data
Google-Code-Issue
Great-Tip!
Help Wanted
HTML-Output
Inadequate-Data-Source
Interesting-problem
Intermittent-issue
Invalid
Invalid-Leave-Visible
JSON-XML-export
Legacy Issue - Non Current inxi
Legacy Issue - Pre v 3.0
Locales
Microsoft WSL
MIPS-CPU
Not-Currently-Possible
Ongoing-Updates
OSX
Outside-Of-Program-Scope
Oversight
Packaging
Patch
PPC
Priority-High
Priority-Low
Priority-Medium
Priority-None
Question
Required-Debugger-Data-Ignored
Required-Work-Not-Done
Requires-Code
Requires-Debugger-Data
Requires-Docs
Requires-Research
Review
RTFM-(or -h)
SSH-Access-Not-Given
SSH-Required
Task
Waiting-Fix-Confirm
Wayland
Windows
Won't-Fix
ZFS
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
smxi/inxi!99
Reference in a new issue
smxi/inxi
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?