5
42
Fork
You've already forked inxi
2

unmounted partitions: GPT on legacy BIOS #235

Closed
arrjay wants to merge 1 commit from gpt-legacyboot into master
pull from: gpt-legacyboot
merge into: smxi:master
smxi:master
smxi:two
smxi:one
arrjay commented 2020年10月31日 03:22:45 +01:00 (Migrated from github.com)
Copy link

parted has support in the GPT partitions it creates for classic BIOS booting, it handles this by using partition flags to mark a "legacy boot" partition. to start digging into it, collect the partition flags from lsblk.

I'm tempted to mark this as something to straight out hide from display, but I can also see tagging these as "legacy_bios" in the unmounted display.

parted has support in the GPT partitions it creates for classic BIOS booting, it handles this by using partition flags to mark a "legacy boot" partition. to start digging into it, collect the partition flags from lsblk. I'm tempted to mark this as something to straight out hide from display, but I can also see tagging these as "legacy_bios" in the unmounted display.
smxi commented 2020年10月31日 03:44:22 +01:00 (Migrated from github.com)
Copy link

note that nothing gets pushed to the stable current master inxi, everything goes to pinxi, I just committed this to pinxi however. I generally don't accept git pulls/pushes etc however because I'm often working on pinxi locally and it's a pain trying to deal with changes coming from elsewhere, but it's easy enough to just copy over the patch if it's basic.

I don't actually use git or its features, to be clear, the real master is my local pinxi, which I then push whenever it seems to be working ok to the github pinxi, so I can grab it more easily from other systems, and other people can check it for fixes etc, and inxi itself is never updated until next inxi happens, which is when current local pinxi gets copied over to inxi, and a few small things changed, then inxi next is pushed to github, but inxi itself is never anything other than the last 'stable' version of pinxi that was copied to inxi master branch [not merged, copied, as in a file replacing another file]. The only time I run inxi is right before I commit next inxi to github, to make sure it's not crashing, but otherwise I don't use inxi at all, since it's always behind inxi except for the day of release, when they are pretty much the same.

Note that partition/unmounted/disk/raid are a real pain to work with because they are all interconnected, so I tread very carefully in this area.

note that nothing gets pushed to the stable current master inxi, everything goes to pinxi, I just committed this to pinxi however. I generally don't accept git pulls/pushes etc however because I'm often working on pinxi locally and it's a pain trying to deal with changes coming from elsewhere, but it's easy enough to just copy over the patch if it's basic. I don't actually use git or its features, to be clear, the real master is my local pinxi, which I then push whenever it seems to be working ok to the github pinxi, so I can grab it more easily from other systems, and other people can check it for fixes etc, and inxi itself is never updated until next inxi happens, which is when current local pinxi gets copied over to inxi, and a few small things changed, then inxi next is pushed to github, but inxi itself is never anything other than the last 'stable' version of pinxi that was copied to inxi master branch [not merged, copied, as in a file replacing another file]. The only time I run inxi is right before I commit next inxi to github, to make sure it's not crashing, but otherwise I don't use inxi at all, since it's always behind inxi except for the day of release, when they are pretty much the same. Note that partition/unmounted/disk/raid are a real pain to work with because they are all interconnected, so I tread very carefully in this area.
arrjay commented 2020年10月31日 04:38:13 +01:00 (Migrated from github.com)
Copy link

ah! i was wondering on the interconnectedness here. I'm going to play about in my local copy, but I figured at least adding more stuff to collect would be a good starting point. I'll see what I get.

ah! i was wondering on the interconnectedness here. I'm going to play about in my local copy, but I figured at least adding more stuff to collect would be a good starting point. I'll see what I get.
smxi commented 2020年10月31日 22:36:43 +01:00 (Migrated from github.com)
Copy link

When I did the rewrite of old inxi to perl, the last components I did were those 4, because they are by far the most complicated and interwoven of anything in inxi/pinxi. But you are right that adding more stuff to collect is in general a good idea, you can see in the debugger data collector stuff that I've added for that reason, but never actually used in inxi, sometimes because it's just not clera what the data really is in the real world, the variety, etc, sometimes because the tools are not consistent or available on most systems, it varies.

When I did the rewrite of old inxi to perl, the last components I did were those 4, because they are by far the most complicated and interwoven of anything in inxi/pinxi. But you are right that adding more stuff to collect is in general a good idea, you can see in the debugger data collector stuff that I've added for that reason, but never actually used in inxi, sometimes because it's just not clera what the data really is in the real world, the variety, etc, sometimes because the tools are not consistent or available on most systems, it varies.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Android
Ansible-Chef-Motd
related to running inxi inside of these tools
Apple-output-error-fixes-only
OSX is not supported beyond fixing Perl output errors.
ARM-CPU
BSD
Bug-Reproduced
BUG!
Character-encoding-issue
Chuckler
Brings a smile...
Close-If-No-Response
Closed-No-Response
Once a user fails to respond, within a few weeks, replace close if no response label with this one
Completed
Cygwin
yep, running on windows!!
Defect
Desktop-ID
Duplicate
Enhancement
Feature-not-a-bug
The issue is about an inxi feature that is intended, and is not a bug
Feature-request-exists
A feature request issue for something inxi already supports
Fixed
Flatpak-Snap-Appimage
FreeBSD-closed-no-data-supplied
Tired of having to get Linux users to do FreeBSD's work for them, no data, no help!
Garbage-Data
Google-Code-Issue
Great-Tip!
Help Wanted
HTML-Output
related to adding html output switch
Inadequate-Data-Source
Interesting-problem
Not necessarily related to inxi but still interesting.
Intermittent-issue
Issue comes and goes, and is not inxi related, though inxi exposes it when it happens
Invalid
Invalid-Leave-Visible
JSON-XML-export
Legacy Issue - Non Current inxi
Legacy Issue - Pre v 3.0
Locales
non C locales support
Microsoft WSL
MIPS-CPU
Mips, Loongson
Not-Currently-Possible
Ongoing-Updates
OSX
Outside-Of-Program-Scope
Oversight
Forgot to add in data type in one area
Packaging
packaging issues belong to the distro making the package. With one exception: TinyCore.
Patch
PPC
Priority-High
Priority-Low
Priority-Medium
Priority-None
Question
Required-Debugger-Data-Ignored
The poster failed to supply the required debugger data, and so the issue cannot be resolved.
Required-Work-Not-Done
If one of the Required labels was applied, and the issue poster did not do that work, and I did, keep this as a reminder.
Requires-Code
This issue requires the person making the request supply the code needed to resolve the issue.
Requires-Debugger-Data
This issue poster must supply the requested debugger data, it cannot be resolved without it.
Requires-Docs
This issue requires that the person requesting it supply the related documentation data and files.
Requires-Research
This issue requires that the poster do the research needed to understand and complete the issue. Research is easily 95% of any task in inxi.
Review
RTFM-(or -h)
Yes, an issue cased by not reading anything.
SSH-Access-Not-Given
SSH-Required
no support without SSH access, non trivial system issue.
Task
Waiting-Fix-Confirm
Wayland
anything where wayland seems to be the cause
Windows
No, really, people have asked!
Won't-Fix
ZFS
ZFS fs specific issues
No labels
Android
Ansible-Chef-Motd
Apple-output-error-fixes-only
ARM-CPU
BSD
Bug-Reproduced
BUG!
Character-encoding-issue
Chuckler
Close-If-No-Response
Closed-No-Response
Completed
Cygwin
Defect
Desktop-ID
Duplicate
Enhancement
Feature-not-a-bug
Feature-request-exists
Fixed
Flatpak-Snap-Appimage
FreeBSD-closed-no-data-supplied
Garbage-Data
Google-Code-Issue
Great-Tip!
Help Wanted
HTML-Output
Inadequate-Data-Source
Interesting-problem
Intermittent-issue
Invalid
Invalid-Leave-Visible
JSON-XML-export
Legacy Issue - Non Current inxi
Legacy Issue - Pre v 3.0
Locales
Microsoft WSL
MIPS-CPU
Not-Currently-Possible
Ongoing-Updates
OSX
Outside-Of-Program-Scope
Oversight
Packaging
Patch
PPC
Priority-High
Priority-Low
Priority-Medium
Priority-None
Question
Required-Debugger-Data-Ignored
Required-Work-Not-Done
Requires-Code
Requires-Debugger-Data
Requires-Docs
Requires-Research
Review
RTFM-(or -h)
SSH-Access-Not-Given
SSH-Required
Task
Waiting-Fix-Confirm
Wayland
Windows
Won't-Fix
ZFS
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
smxi/inxi!235
Reference in a new issue
smxi/inxi
No description provided.
Delete branch "gpt-legacyboot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?