fix where source line parser when loaded from luaL_loadstring #89

ZSaberLv0 commented 2025年03月10日 15:00:01 +01:00 (Migrated from github.com)

assume source input string, and load from C by luaL_loadstring:

---@type number
local a = 1
dbg() -- break here and use `where`
a = a + 1

there are two problems:

1. the info.currentline would be 5, while the source's empty lines would be ignored, result to length 4
2. the ---@type 's @ would be used as filename pattern, which was not right

both of these problems would results to Error: Source not available for xxx

assume source input string, and load from C by `luaL_loadstring`: ``` ---@type number local a = 1 dbg() -- break here and use `where` a = a + 1 ``` there are two problems: 1. the `info.currentline` would be `5`, while the `source`'s empty lines would be ignored, result to length `4` 2. the `---@type` 's `@` would be used as filename pattern, which was not right both of these problems would results to `Error: Source not available for xxx`

slembcke commented 2025年03月25日 21:57:06 +01:00 (Migrated from github.com)

Is it only possible to trigger this bug from the C API? I tried just using "load" from Lua, but couldn't reproduce it to make a test. Otherwise it seems to pass the rest of the tests?

Good catch on the filename pattern... I know that worked at some point... I wonder when I broke that. whoops... (Always need more tests, sigh)

Is it only possible to trigger this bug from the C API? I tried just using "load" from Lua, but couldn't reproduce it to make a test. Otherwise it seems to pass the rest of the tests? Good catch on the filename pattern... I know that worked at some point... I wonder when I broke that. whoops... (Always need more tests, sigh)

ZSaberLv0 commented 2025年03月26日 02:19:23 +01:00 (Migrated from github.com)

dbg = require('debugger')
local f = load([[
 ---@type number
 local a = 1
 dbg() -- break here and use `where`
 a = a + 1
 ]])
f()

also reproduceable in lua, note for the extra emtpy lines and ---@type

``` lua dbg = require('debugger') local f = load([[ ---@type number local a = 1 dbg() -- break here and use `where` a = a + 1 ]]) f() ``` also reproduceable in lua, note for the extra emtpy lines and `---@type`

slembcke commented 2025年03月26日 06:14:40 +01:00 (Migrated from github.com)

Hrm, I tried exactly that... Will poke at it again tomorrow.

Hrm, I tried exactly that... Will poke at it again tomorrow.