2
8
Fork
You've already forked Chipmunk2D
3

Fix MSVC dll import/export #229

Open
airbrett wants to merge 4 commits from airbrett/master into master
pull from: airbrett/master
merge into: slembcke:master
slembcke:master
slembcke:6.2.x
slembcke:glfw3
slembcke:cpp
slembcke:GL3
slembcke:GLFW-refactor
slembcke:custom-contact
slembcke:UnityTemp
slembcke:6.1.x
slembcke:speculative
slembcke:surfacev
airbrett commented 2022年10月01日 16:02:23 +02:00 (Migrated from github.com)
Copy link

Problem: When building a dll on Windows with MSVC some symbols are not exported while others are exported with C++ name mangling rather than C.

Solution: Add CP_EXPORT to functions not exported. Add define block to handle __declspec(dllexport) and __declspec(dllimport). Note: this solution requires a new define added to instruct the compiler to look for a shared library or a static library. This only applies when _WIN32 is defined.

This may fix #194, #116 and possibly #121

Problem: When building a dll on Windows with MSVC some symbols are not exported while others are exported with C++ name mangling rather than C. Solution: Add CP_EXPORT to functions not exported. Add define block to handle __declspec(dllexport) and __declspec(dllimport). Note: this solution requires a new define added to instruct the compiler to look for a shared library or a static library. This only applies when _WIN32 is defined. This may fix #194, #116 and possibly #121
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin airbrett/master:airbrett/master
git switch airbrett/master

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff airbrett/master
git switch airbrett/master
git rebase master
git switch master
git merge --ff-only airbrett/master
git switch airbrett/master
git rebase master
git switch master
git merge --no-ff airbrett/master
git switch master
git merge --squash airbrett/master
git switch master
git merge --ff-only airbrett/master
git switch master
git merge airbrett/master
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
slembcke/Chipmunk2D!229
Reference in a new issue
slembcke/Chipmunk2D
No description provided.
Delete branch "airbrett/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?