skyblock_zero/skyblock_zero
3
6
Fork
You've already forked skyblock_zero
9

Refactor and Improve Copytool #120

Open
AbbyRead wants to merge 8 commits from AbbyRead/skyblock_zero:copytool-flatten into master
pull from: AbbyRead/skyblock_zero:copytool-flatten
merge into: skyblock_zero:master
skyblock_zero:master
skyblock_zero:v45.1
skyblock_zero:46rc2
skyblock_zero:luacontroller_fixups
skyblock_zero:new_luacontrollers

I wanted to improve the copytool enough to justify it's texture being replaced to a much snazzier one by lucenec dummy. That led me down a long path of trying to understand the metatool API though, which led me down a rabbithole of trying to fix the gripes I had with it. I think both metatool and copytool are in a pretty good spot now, so I'm taking the WIP marker off the PR, having squashed most of the commits into more logical chunks. I'll squash more once I get the go-ahead, but since there are a lot of changes, I wanted to make sure they read well enough for the reviews at least.

I wanted to improve the copytool enough to justify it's texture being replaced to a much snazzier one by lucenec dummy. That led me down a long path of trying to understand the metatool API though, which led me down a rabbithole of trying to fix the gripes I had with it. I think both metatool and copytool are in a pretty good spot now, so I'm taking the WIP marker off the PR, having squashed most of the commits into more logical chunks. I'll squash more once I get the go-ahead, but since there are a lot of changes, I wanted to make sure they read well enough for the reviews at least.
Refactor: Just make names read the way they are. wtf
Refactor: Explain channel mode parsing
Refactor: Include a tp_tube_helpers.lua dofile call in any.lua
Refactor: Add a tp_tube_helpers.lua header comment
Refactor: Finish killing the use of namespace for helpers
AbbyRead changed title from (削除) WIP: Refactor and Improve Copytool (削除ここまで) to Refactor and Improve Copytool 2026年06月27日 11:02:05 +02:00
Author
Owner
Copy link

See now the newly rebased commits (since they don't show up on the conversation page the right way after the force push: #120/commits

See now the newly rebased commits (since they don't show up on the conversation page the right way after the force push: https://codeberg.org/skyblock_zero/skyblock_zero/pulls/120/commits
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u copytool-flatten:AbbyRead-copytool-flatten
git switch AbbyRead-copytool-flatten

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff AbbyRead-copytool-flatten
git switch AbbyRead-copytool-flatten
git rebase master
git switch master
git merge --ff-only AbbyRead-copytool-flatten
git switch AbbyRead-copytool-flatten
git rebase master
git switch master
git merge --no-ff AbbyRead-copytool-flatten
git switch master
git merge --squash AbbyRead-copytool-flatten
git switch master
git merge --ff-only AbbyRead-copytool-flatten
git switch master
git merge AbbyRead-copytool-flatten
git push origin master
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat
Breaking
 Breaking change that won't be backward compatible
contribution welcome
Contributions are very welcome, get started here
good first issue
Interested in contributing? Get started here.
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Kind/Translation
Changes related to translation
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
skyblock_zero/skyblock_zero!120
Reference in a new issue
skyblock_zero/skyblock_zero
No description provided.
Delete branch "AbbyRead/skyblock_zero:copytool-flatten"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?