simonrepp/faircamp
24
334
Fork
You've already forked faircamp
46

Fix release embed track links #141

Merged
simonrepp merged 2 commits from :embed into main 2025年01月08日 13:14:44 +01:00
Contributor
Copy link

I noticed that currently, the track links in release (/all/) embeds lead to a non-existent page. For example, at https://faircamp.sny.sh/starlab-legacy/embed/all/, "1. Relaxing Beats" leads to https://faircamp.sny.sh/starlab-legacy/embed/all/1/.

In 5aa03e3d4c I updated the link to point to the correct URL (I hope I didn't miss any edge cases).

I also set the links to open in the parent context (i. e. the page the embed is located in, instead of the potentially very small embed itself) in 65128dc08b.

I noticed that currently, the track links in release (`/all/`) embeds lead to a non-existent page. For example, at https://faircamp.sny.sh/starlab-legacy/embed/all/, "1. Relaxing Beats" leads to https://faircamp.sny.sh/starlab-legacy/embed/all/1/. In `5aa03e3d4c` I updated the link to point to the correct URL (I hope I didn't miss any edge cases). I also set the links to open in the parent context (i. e. the page the embed is located in, instead of the potentially very small embed itself) in `65128dc08b`.

Looks great, thanks a lot for fixing these!

Looks great, thanks a lot for fixing these!
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
simonrepp/faircamp!141
Reference in a new issue
simonrepp/faircamp
No description provided.
Delete branch ":embed"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?