Not your mistake (just something I haven't yet adressed in the automatic code generation, sorry), but continue is a reserved keyword in rust, and hence needs to be escaped like this:

 r#continue: Reviewed("Doorgaan"),

Not your mistake (just something I haven't yet adressed in the automatic code generation, sorry), but `continue` is a reserved keyword in rust, and hence needs to be escaped like this: ``` r#continue: Reviewed("Doorgaan"), ```

simonrepp commented

2024年11月15日 23:46:04 +01:00

Owner

Copy link

Very cool, thanks a lot for this PR!

I pointed out the one thing that's technically a problem, but I can also fix this after merging, whichever way you prefer! :)

Very cool, thanks a lot for this PR! I pointed out the one thing that's technically a problem, but I can also fix this after merging, whichever way you prefer! :)

n3wjack commented

2024年11月16日 09:31:24 +01:00

Author

Contributor

Copy link

Feel free to merge and fix this.
I thought this was probably the easiest way for you to get the translations in the codebase.
But I don't know Rust, so I didn't actually try to compile it, as I don't have the whole toolchain installed. 😬😱

Feel free to merge and fix this. I thought this was probably the easiest way for you to get the translations in the codebase. But I don't know Rust, so I didn't actually try to compile it, as I don't have the whole toolchain installed. 😬😱

👍 1

simonrepp merged commit 1101b941b1 into main

2024年11月16日 09:48:33 +01:00

simonrepp commented

2024年11月16日 10:06:42 +01:00

Owner

Copy link

Merged and wrapped up. \o/

This was indeed the most easy way for me, thanks a lot for taking the time to provide it like that! (I'd also skip the toolchain myself, fully understand, can't install/maintain every tech stack on this planet constantly :))

Merged and wrapped up. \o/ This was indeed the most easy way for me, thanks a lot for taking the time to provide it like that! (I'd also skip the toolchain myself, fully understand, can't install/maintain every tech stack on this planet constantly :))

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

simonrepp/faircamp!122

No description provided.

Delete branch "n3wjack/faircamp:n3wjack-nl-translations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?