fix new "var never mutated" error on Zig 0.12.0-dev.1663+6b1a823b2 #231

BratishkaErik commented 2023年11月20日 09:46:18 +01:00 (Migrated from code.blicky.net)

Fixes these errors (introduced in https://github.com/ziglang/zig/pull/18017
and github.com/ziglang/zig@6b1a823b2b ):

src/main.zig:290:13: error: local variable is never mutated
 var line_ = line_fbs.getWritten();
 ^~~~~
src/main.zig:290:13: note: consider using 'const'
src/main.zig:450:17: error: local variable is never mutated
 var path = std.fs.path.joinZ(allocator, &.{p, "ncdu", "config"}) catch unreachable;
 ^~~~
src/main.zig:450:17: note: consider using 'const'
...

Will be included in future Zig 0.12, this fix is backward compatible:
ncdu still builds and runs fine on Zig 0.11.0.

Signed-off-by: Eric Joldasov bratishkaerik@getgoogleoff.me

Fixes these errors (introduced in https://github.com/ziglang/zig/pull/18017 and https://github.com/ziglang/zig/commit/6b1a823b2b30d9318c9877dbdbd3d02fa939fba0 ): ``` src/main.zig:290:13: error: local variable is never mutated var line_ = line_fbs.getWritten(); ^~~~~ src/main.zig:290:13: note: consider using 'const' src/main.zig:450:17: error: local variable is never mutated var path = std.fs.path.joinZ(allocator, &.{p, "ncdu", "config"}) catch unreachable; ^~~~ src/main.zig:450:17: note: consider using 'const' ... ``` Will be included in future Zig 0.12, this fix is backward compatible: ncdu still builds and runs fine on Zig 0.11.0. Signed-off-by: Eric Joldasov <bratishkaerik@getgoogleoff.me>

yorhel commented 2023年11月20日 09:59:14 +01:00 (Migrated from code.blicky.net)

Pulled.

(I still have this faint hope that they'll eventually change silly lint issues into warnings instead of their current insistence on a -Werror approach. shrug)

Pulled. (I still have this faint hope that they'll eventually change silly lint issues into warnings instead of their current insistence on a `-Werror` approach. *shrug*)

BratishkaErik commented 2023年11月20日 10:12:30 +01:00 (Migrated from code.blicky.net)

Pulled.

(I still have this faint hope that they'll eventually change silly lint issues into warnings instead of their current insistence on a -Werror approach. shrug)

Well, ZLS has some collection of autofixes for these (削除) warnings (削除ここまで) errors, but yes, it's rather unfortunate...

> Pulled. > > (I still have this faint hope that they'll eventually change silly lint issues into warnings instead of their current insistence on a `-Werror` approach. *shrug*) Well, ZLS has some collection of autofixes for these ~~warnings~~ errors, but yes, it's rather unfortunate...