2
3
Fork
You've already forked ncsu
0

Makefile: Add ZIG variable and build target #220

Closed
Flow wants to merge 0 commits from makefile into zig
pull from: makefile
merge into: selfisekai:zig
selfisekai:zig
selfisekai:zig0.16
selfisekai:master
selfisekai:zig-threaded
selfisekai:openat
selfisekai:chdir
selfisekai:clear
selfisekai:compll
Flow commented 2023年03月09日 16:07:57 +01:00 (Migrated from code.blicky.net)
Copy link

The ZIG variable helps to test ncdu with different zig installations,
and it allows Gentoo to inject the zig version that should be used to
build zig into the Makefile.

Also add a phony 'build' target as first target to the Makefile so
that it becomes the default target. This allows the Gentoo package to
use the default src_compile() function.

See also https://bugs.gentoo.org/900547

The ZIG variable helps to test ncdu with different zig installations, and it allows Gentoo to inject the zig version that should be used to build zig into the Makefile. Also add a phony 'build' target as first target to the Makefile so that it becomes the default target. This allows the Gentoo package to use the default src_compile() function. See also https://bugs.gentoo.org/900547
yorhel commented 2023年03月09日 16:22:50 +01:00 (Migrated from code.blicky.net)
Copy link

Pulled. Not having 'doc' as part of the default target was kind of intentional, as I'm sure not everyone has pod2man installed and not everyone is interested in the man page. But ncdu.1 is included in the tarball and with the right the timestamps that should ensure it won't be built anyway. Peolpe can always just run zig build directly, too, so whatever.

Thanks for your work on Gentoo, much appreciated!

Pulled. Not having 'doc' as part of the default target was kind of intentional, as I'm sure not everyone has pod2man installed and not everyone is interested in the man page. But `ncdu.1` is included in the tarball and with the right the timestamps that *should* ensure it won't be built anyway. Peolpe can always just run `zig build` directly, too, so whatever. Thanks for your work on Gentoo, much appreciated!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No labels
1.x
2.x
bug
feature
imported
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
selfisekai/ncsu!220
Reference in a new issue
selfisekai/ncsu
No description provided.
Delete branch "makefile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?