2
3
Fork
You've already forked ncsu
0

Use Natural Sort by Name in v1.x #182

Closed
cipri_tom wants to merge 0 commits from master into master
pull from: master
merge into: selfisekai:master
selfisekai:zig
selfisekai:zig0.16
selfisekai:zig-threaded
selfisekai:openat
selfisekai:chdir
selfisekai:clear
selfisekai:compll
cipri_tom commented 2021年12月22日 15:42:47 +01:00 (Migrated from code.blicky.net)
Copy link

Hi,

I've changed sorting by name to use natural sort, as per #181, but currently only for C-version, so v1.x

Since the code is so well organised, the implementation was straighforward, with minimal changes, using the free C code of Martin Pool (gratis & libre & unrestricted), from here: https://github.com/sourcefrog/natsort .

I've run it locally in Ubuntu 18.04 and works well. See attached for difference between v1.12 and this commit.

Hi, I've changed sorting by name to use natural sort, as per #181, but currently only for C-version, so v1.x Since the code is so well organised, the implementation was straighforward, with minimal changes, using the free C code of Martin Pool (gratis & libre & unrestricted), from here: https://github.com/sourcefrog/natsort . I've run it locally in Ubuntu 18.04 and works well. See attached for difference between v1.12 and this commit.
yorhel commented 2021年12月22日 16:25:25 +01:00 (Migrated from code.blicky.net)
Copy link

Heh, that's a simple PR indeed. Though I'd suggest one change: strnatcmp.[ch] should be in deps/, and Makefile.am has an update-deps target that should be updated to fetch those two files (which is admittedly more for documentation of the origin than actual updating, I don't think I've ever ran the target...)

Heh, that's a simple PR indeed. Though I'd suggest one change: `strnatcmp.[ch]` should be in deps/, and Makefile.am has an `update-deps` target that should be updated to fetch those two files (which is admittedly more for documentation of the origin than actual updating, I don't think I've ever ran the target...)
cipri_tom commented 2021年12月23日 10:10:39 +01:00 (Migrated from code.blicky.net)
Copy link

Thanks for the suggestion ! I've moved them and added them to update-deps target.

Running the target also brings changes to the other deps, which I have not committed.

Thanks for the suggestion ! I've moved them and added them to `update-deps` target. Running the target also brings changes to the other deps, which I have not committed.
yorhel commented 2021年12月24日 16:14:33 +01:00 (Migrated from code.blicky.net)
Copy link

Pulled, thanks.

Pulled, thanks.
rofl commented 2022年01月02日 12:54:34 +01:00 (Migrated from code.blicky.net)
Copy link

note that identifiers starting with str[a-z] are reserved identifiers in the POSIX namespace rules https://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier

note that identifiers starting with str[a-z] are reserved identifiers in the POSIX namespace rules https://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
No labels
1.x
2.x
bug
feature
imported
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
selfisekai/ncsu!182
Reference in a new issue
selfisekai/ncsu
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?