12
0
Fork
You've already forked website
0

Rework navigation #42

Merged
itrich merged 1 commit from feat/rework-nav into master 2022年06月23日 20:56:15 +02:00
itrich commented 2022年06月23日 10:32:37 +02:00 (Migrated from github.com)
Copy link

This PR reworks the navigation as proposed today (2022年06月23日) in Mattermost, including the following changes:

  • Remove "w3lc0m3", "Corona Info" nav item
  • Move "Impressum" nav item to footer
  • Add "Chat" nav item
This PR reworks the navigation as proposed today (2022年06月23日) in Mattermost, including the following changes: - Remove "w3lc0m3", "Corona Info" nav item - Move "Impressum" nav item to footer - Add "Chat" nav item
justinotherguy commented 2022年06月23日 11:31:14 +02:00 (Migrated from github.com)
Copy link

LGTM!

LGTM!
paepke (Migrated from github.com) requested changes 2022年06月23日 11:39:01 +02:00
@ -48,4 +48,3 @@
<div class="navbar-menu" id="navMenu">
<div class="navbar-start">
<a {% if this._path == '/' %} class="is-active navbar-item"{% else %}class="navbar-item"{% endif %} href="{{ '/'|url }}">w3lc0m3!</a>
{% for href, title in [
paepke (Migrated from github.com) commented 2022年06月23日 11:38:51 +02:00
Copy link

You can't come back to home "/" without this link. Suggest keeping this, but with an other name.

You can't come back to home "/" without this link. Suggest keeping this, but with an other name.
itrich (Migrated from github.com) reviewed 2022年06月23日 11:40:16 +02:00
@ -48,4 +48,3 @@
<div class="navbar-menu" id="navMenu">
<div class="navbar-start">
<a {% if this._path == '/' %} class="is-active navbar-item"{% else %}class="navbar-item"{% endif %} href="{{ '/'|url }}">w3lc0m3!</a>
{% for href, title in [
itrich (Migrated from github.com) commented 2022年06月23日 11:40:16 +02:00
Copy link

You can always click on the icon (which is imho known to most internet users)

You can always click on the icon (which is imho known to most internet users)
paepke (Migrated from github.com) reviewed 2022年06月23日 11:44:01 +02:00
@ -48,4 +48,3 @@
<div class="navbar-menu" id="navMenu">
<div class="navbar-start">
<a {% if this._path == '/' %} class="is-active navbar-item"{% else %}class="navbar-item"{% endif %} href="{{ '/'|url }}">w3lc0m3!</a>
{% for href, title in [
paepke (Migrated from github.com) commented 2022年06月23日 11:44:01 +02:00
Copy link

lgtm

lgtm
justinotherguy (Migrated from github.com) reviewed 2022年06月23日 11:45:12 +02:00
@ -48,4 +48,3 @@
<div class="navbar-menu" id="navMenu">
<div class="navbar-start">
<a {% if this._path == '/' %} class="is-active navbar-item"{% else %}class="navbar-item"{% endif %} href="{{ '/'|url }}">w3lc0m3!</a>
{% for href, title in [
justinotherguy (Migrated from github.com) commented 2022年06月23日 11:45:12 +02:00
Copy link

for me the name ("w3lc0me!") is a reason for keeping it; but it's simply a copy of the logo; therefore suggesting to remove it - did we overlook something?

for me the name ("w3lc0me!") is a reason for keeping it; but it's simply a copy of the logo; therefore suggesting to remove it - did we overlook something?
itrich (Migrated from github.com) reviewed 2022年06月23日 11:47:09 +02:00
@ -48,4 +48,3 @@
<div class="navbar-menu" id="navMenu">
<div class="navbar-start">
<a {% if this._path == '/' %} class="is-active navbar-item"{% else %}class="navbar-item"{% endif %} href="{{ '/'|url }}">w3lc0m3!</a>
{% for href, title in [
itrich (Migrated from github.com) commented 2022年06月23日 11:47:09 +02:00
Copy link

The leetspeak can also be found on the landing page 😋

The leetspeak can also be found on the landing page 😋
justinotherguy (Migrated from github.com) reviewed 2022年06月23日 11:51:13 +02:00
@ -48,4 +48,3 @@
<div class="navbar-menu" id="navMenu">
<div class="navbar-start">
<a {% if this._path == '/' %} class="is-active navbar-item"{% else %}class="navbar-item"{% endif %} href="{{ '/'|url }}">w3lc0m3!</a>
{% for href, title in [
justinotherguy (Migrated from github.com) commented 2022年06月23日 11:51:13 +02:00
Copy link

true! :)

true! :)
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
section77/website!42
Reference in a new issue
section77/website
No description provided.
Delete branch "feat/rework-nav"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?