Add transient-based question UI with multi-select support #22

avph commented 2026年02月09日 20:35:31 +01:00

Replaces the completion-based question prompt with a transient popup
that supports single-select (radio), multi-select (checkbox), and custom
text input modes, providing a more flexible and user-friendly interface
for answering server questions.

Signed-off-by: Arthur Heymans arthur@aheymans.xyz

Replaces the completion-based question prompt with a transient popup that supports single-select (radio), multi-select (checkbox), and custom text input modes, providing a more flexible and user-friendly interface for answering server questions. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>

sczi commented 2026年02月11日 04:27:20 +01:00

Thanks, I wasn't thrilled with the completing-read question interface it was just the easiest way to get something working. This looks nicer. But the transient menu is broken for me (emacs 30.2), keys or mouse don't toggle anything. I don't have time to debug it now but opus claims "The transient is invoked before recursive-edit, so it gets set up in the parent command loop context, not inside the recursive edit's command loop. This causes the transient's key-handling machinery to malfunction." And indeed without the recursive-edit the transient menu works fine, but then doesn't return the result. Maybe the simplest solution would be to just have transient-exit-hook call the reject-question api, and opencode-question--do-confirm call the reply api, and then not need the whole recursive-edit to try and block for the result?

Thanks, I wasn't thrilled with the completing-read question interface it was just the easiest way to get something working. This looks nicer. But the transient menu is broken for me (emacs 30.2), keys or mouse don't toggle anything. I don't have time to debug it now but opus claims "The transient is invoked before recursive-edit, so it gets set up in the parent command loop context, not inside the recursive edit's command loop. This causes the transient's key-handling machinery to malfunction." And indeed without the recursive-edit the transient menu works fine, but then doesn't return the result. Maybe the simplest solution would be to just have transient-exit-hook call the reject-question api, and opencode-question--do-confirm call the reply api, and then not need the whole recursive-edit to try and block for the result?

avph commented 2026年03月24日 13:32:55 +01:00

@sczi wrote in #22 (comment):

Thanks, I wasn't thrilled with the completing-read question interface it was just the easiest way to get something working. This looks nicer. But the transient menu is broken for me (emacs 30.2), keys or mouse don't toggle anything. I don't have time to debug it now but opus claims "The transient is invoked before recursive-edit, so it gets set up in the parent command loop context, not inside the recursive edit's command loop. This causes the transient's key-handling machinery to malfunction." And indeed without the recursive-edit the transient menu works fine, but then doesn't return the result. Maybe the simplest solution would be to just have transient-exit-hook call the reject-question api, and opencode-question--do-confirm call the reply api, and then not need the whole recursive-edit to try and block for the result?

done. It seems to work well now

@sczi wrote in https://codeberg.org/sczi/opencode.el/pulls/22#issuecomment-10507758: > Thanks, I wasn't thrilled with the completing-read question interface it was just the easiest way to get something working. This looks nicer. But the transient menu is broken for me (emacs 30.2), keys or mouse don't toggle anything. I don't have time to debug it now but opus claims "The transient is invoked before recursive-edit, so it gets set up in the parent command loop context, not inside the recursive edit's command loop. This causes the transient's key-handling machinery to malfunction." And indeed without the recursive-edit the transient menu works fine, but then doesn't return the result. Maybe the simplest solution would be to just have transient-exit-hook call the reject-question api, and opencode-question--do-confirm call the reply api, and then not need the whole recursive-edit to try and block for the result? done. It seems to work well now

sczi commented 2026年03月27日 18:29:22 +01:00

thanks, I made a little change to make it a bit faster to use for single choice questions, selecting an option immediately answers the question, and C-c C-c to respond is only used for multiple choice questions, and updated the question tool section of the readme and merged

thanks, I made a little change to make it a bit faster to use for single choice questions, selecting an option immediately answers the question, and `C-c C-c` to respond is only used for multiple choice questions, and updated the question tool section of the readme and merged