1
4
Fork
You've already forked scripty
1

Add better ping fail message #15

Closed
randomairborne wants to merge 1 commit from valk/better-ping into master
pull from: valk/better-ping
merge into: scripty-bot:master
scripty-bot:master
scripty-bot:tts
scripty-bot:broken-do-not-use
scripty-bot:valk/humanize-duration
scripty-bot:no-nickname-change
scripty-bot:voice-chat-mod
randomairborne commented 2022年11月18日 18:25:29 +01:00 (Migrated from github.com)
Copy link

This PR improves the failure message for the ping command

This PR improves the failure message for the ping command
tazz4843 left a comment
Copy link

Way too prone to other languages breaking (don't be Anglocentric). Use entirely new strings if you need to in the translation files.

Way too prone to other languages breaking (don't be Anglocentric). Use entirely new strings if you need to in the translation files.
randomairborne commented 2022年11月18日 20:51:35 +01:00 (Migrated from github.com)
Copy link

i did add some new strings. There isn’t a great way to do this without the actual translators getting involved and helping actually write the messages, using an auto translator for long strings is somewhat sketch

On Fri, Nov 18, 2022 at 11:18, tazz4843 @.***> wrote:

@tazz4843 requested changes on this pull request.

Way too prone to other languages breaking (don't be Anglocentric). Use entirely new strings if you need to in the translation files.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

i did add some new strings. There isn’t a great way to do this without the actual translators getting involved and helping actually write the messages, using an auto translator for long strings is somewhat sketch On Fri, Nov 18, 2022 at 11:18, tazz4843 ***@***.***> wrote: > @tazz4843 requested changes on this pull request. > > Way too prone to other languages breaking (don't be Anglocentric). Use entirely new strings if you need to in the translation files. > > — > Reply to this email directly, [view it on GitHub](https://github.com/scripty-bot/scripty/pull/15#pullrequestreview-1186587012), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AQPUP7X3DOTRIFOZGGWCVYDWI7CANANCNFSM6AAAAAASEWXQBQ). > You are receiving this because you authored the thread.Message ID: ***@***.***>

Can't merge this then, screws with other languages too much.

Can't merge this then, screws with other languages too much.
randomairborne commented 2022年11月18日 21:14:48 +01:00 (Migrated from github.com)
Copy link

What other options do you propose? The way it's done now is very messy.

What other options do you propose? The way it's done now is very messy.
randomairborne commented 2022年11月18日 21:18:52 +01:00 (Migrated from github.com)
Copy link

This decision also makes it pretty impossible to ever change formatting on a message, as you need all of the translators to update along in the same PR.

This decision also makes it pretty impossible to ever change formatting on a message, as you need all of the translators to update along in the same PR.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
scripty-bot/scripty!15
Reference in a new issue
scripty-bot/scripty
No description provided.
Delete branch "valk/better-ping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?