1
0
Fork
You've already forked pyfedi
0
forked from rimu/pyfedi

Fix critical S3 logo upload issues #14

Merged
saint merged 7 commits from s3-migration-support into main 2025年10月02日 23:30:35 +02:00
Owner
Copy link
  • Transaction safety: Delete files AFTER database commit, not before
  • Path consistency: Use site/ prefix and full S3 URLs in migration
  • Error handling: Add ClientError handling with rollback on failures
  • Resource cleanup: Track files to delete, only cleanup after successful commit

Files modified:

  • app/admin/routes.py: Admin upload with try/except/finally
  • app/cli.py: Migration command with error handling

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

- Transaction safety: Delete files AFTER database commit, not before - Path consistency: Use site/ prefix and full S3 URLs in migration - Error handling: Add ClientError handling with rollback on failures - Resource cleanup: Track files to delete, only cleanup after successful commit Files modified: - app/admin/routes.py: Admin upload with try/except/finally - app/cli.py: Migration command with error handling 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix critical S3 logo upload issues
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
/ lint (push) Failing after 12s
ci/woodpecker/pr/woodpecker Pipeline failed
/ lint (pull_request) Failing after 9s
4f4adf366c
- Transaction safety: Delete files AFTER database commit, not before
- Path consistency: Use site/ prefix and full S3 URLs in migration
- Error handling: Add ClientError handling with rollback on failures
- Resource cleanup: Track files to delete, only cleanup after successful commit
Files modified:
- app/admin/routes.py: Admin upload with try/except/finally
- app/cli.py: Migration command with error handling
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fix ruff linting errors
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
ci/woodpecker/pr/woodpecker Pipeline failed
/ lint (push) Failing after 10s
/ lint (pull_request) Failing after 11s
67d3581483
- Remove unused exception variables
- Convert f-string to regular string where no placeholders
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
CI: Only lint changed Python files with ruff
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
ci/woodpecker/pr/woodpecker Pipeline failed
/ lint (push) Failing after 13s
/ lint (pull_request) Failing after 13s
65a87522f2
- Get list of changed .py files compared to base branch
- Only run ruff check/format on those files
- Skip linting if no Python files changed
- Prevents failures from pre-existing issues in unmodified files
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Merge branch 'main' into s3-migration-support
Some checks failed
ci/woodpecker/pr/woodpecker Pipeline failed
/ lint (pull_request) Failing after 13s
ci/woodpecker/push/woodpecker Pipeline failed
/ lint (push) Successful in 12s
db3026a85d
CI: Use pip-installed ruff to check only changed files
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
ci/woodpecker/pr/woodpecker Pipeline failed
/ lint (push) Failing after 11s
/ lint (pull_request) Failing after 8s
c73e17dc68
- Run in python:3.11-alpine container
- Install ruff via pip instead of Docker image
- Get list of changed .py files vs base branch
- Only lint/format those specific files
- Avoids Docker daemon requirement and pre-existing issues
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Apply ruff formatting and optimize CI workflow
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
ci/woodpecker/pr/woodpecker Pipeline failed
/ lint (push) Failing after 9s
/ lint (pull_request) Failing after 8s
3390b61f58
- Format S3 logo upload code with ruff
- Update workflow to only check changed Python files
- Fix unused exception variable linting errors
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Fix CI workflow: Remove container, use setup-python action
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
ci/woodpecker/pr/woodpecker Pipeline failed
/ lint (push) Successful in 36s
/ lint (pull_request) Successful in 37s
ci/woodpecker/pull_request_closed/woodpecker Pipeline failed
6798697111
Forgejo Actions needs Node.js to run actions. Instead of using
python:3.11-alpine container (which lacks Node.js), run on the
default runner environment and install Python via setup-python.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
saint deleted branch s3-migration-support 2025年10月02日 23:30:36 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
saint/pyfedi!14
Reference in a new issue
saint/pyfedi
No description provided.
Delete branch "s3-migration-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?