6
24
Fork
You've already forked ifstate
13

Fix perpetual recreation of veth interfaces #76

Merged
liske merged 1 commit from magic_rb/ifstate:fix-perpetual-recreation-of-veth into ifstate-1.x 2025年01月26日 12:37:49 +01:00
Contributor
Copy link

See #64 for context

This does fix the problem, I just don't know how this ever worked since findmnt has been returing JSON at least as far back as 2 years ago (according to git blame), so I'm not sure what I am actually fixing.

I haven't actually tried an apply yet, I don't want my flatmates to yell at me in case something breaks, but a check reports ok.

See #64 for context This does fix the problem, I just don't know how this ever worked since `findmnt` has been returing JSON at least as far back as 2 years ago (according to `git blame`), so I'm not sure what I am actually fixing. I haven't actually tried an apply yet, I don't want my flatmates to yell at me in case something breaks, but a check reports `ok`.
Signed-off-by: magic_rb <richard@brezak.sk>
Author
Contributor
Copy link

Flatmates left for a second so I took the liberty of running a apply and it worked, this PR is functional.

Flatmates left for a second so I took the liberty of running a `apply` and it worked, this PR is functional.
liske added this to the v1.13.3 milestone 2025年01月26日 11:23:35 +01:00
liske merged commit 0f9d27bdf1 into ifstate-1.x 2025年01月26日 12:37:49 +01:00
Owner
Copy link

After more testing it seems that this change fixes it if findmntis not available but breaks setups having findmnt avail. So I dropped the usage of findmnt in 07fa4a2df7.

After more testing it seems that this change fixes it if `findmnt`is **not** available but breaks setups having `findmnt` avail. So I dropped the usage of `findmnt` in 07fa4a2df7889f6e7fffb9b3a655a6695c9395d5.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
more info
Further details are required, the problem may not yet be reproducible, yet
question
Further information is requested
TBD
To be discussed
wontfix
This will not be worked on
AI slop
Burning out
bug
Something is not working
contribution welcome
Contributions are very welcome, get started here
duplicate
This issue or pull request already exists
enhancement
New feature
good first issue
Interested in contributing? Get started here.
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
upstream
Related to an upstream repository, already reported there
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
routerkit/ifstate!76
Reference in a new issue
routerkit/ifstate
No description provided.
Delete branch "magic_rb/ifstate:fix-perpetual-recreation-of-veth"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?