3
1
Fork
You've already forked GSODR
0

export update_station_list() and correct docs #132

Merged
SpatLyu merged 4 commits from main into main 2025年10月26日 13:35:07 +01:00
SpatLyu commented 2025年10月26日 05:26:47 +01:00 (Migrated from github.com)
Copy link

In the README and vignette, I found that the function update_internal_isd_history() is referenced but not defined in the package namespace or internally. At the same time, the package website lists the function update_station_list() in the function reference, but it is not exported in the namespace. Since the functionality of update_internal_isd_history() and update_station_list() seems to overlap, I suspect there might be a mismatch. Therefore, I opened this PR to address it. If my assumption is incorrect, please feel free to ignore or close this PR.

In the README and vignette, I found that the function `update_internal_isd_history()` is referenced but not defined in the package namespace or internally. At the same time, the package website lists the function `update_station_list()` in the function reference, but it is not exported in the namespace. Since the functionality of `update_internal_isd_history()` and `update_station_list()` seems to overlap, I suspect there might be a mismatch. Therefore, I opened this PR to address it. If my assumption is incorrect, please feel free to ignore or close this PR.

Thank you, again, for catching my rookie mistake! You were indeed correct, this was an error on my part. Nice job cleaning it up.

Thank you, again, for catching my rookie mistake! You were indeed correct, this was an error on my part. Nice job cleaning it up.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ropensci/GSODR!132
Reference in a new issue
ropensci/GSODR
No description provided.
Delete branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?