Fork 1

edwardloveall added 3 commits 2026年02月18日 19:22:14 +01:00

A bunch of methods still expected the type of eventable (ShiftEvent) as an argument. But ShiftEvent is unused so we can remove this argument.

Since we don't have two separate models, the separation of their attributes is
not used and adds unneeded complexity. The EventsService and related classes now
act on a single hash of attributes.

Now that all the EventsService objects take a single hash of params, we can
merge them in the view and controller.
I'd love to have better flow for adding tasks and users. The way it works now is
we set `task_ids` (or `user_ids`) in an array with the field_name
`event[task_ids][]`. If the `commit` param is `ADD TASK`, it adds a select tag
with that name, adding another value to the form params.
I also tried to use the `accepts_nested_attributes_for` pattern with
`fields_for(:tasks)`. The problem I ran into there was that rails expects that
the tasks _already_ belong to the event. When you're adding them before creation
or updating, rails throws a get an `ActiveRecord::NotFound` error. Setting an
array of `task_ids` seems to be the best option I can find for now.

edwardloveall referenced this pull request 2026年02月18日 19:23:20 +01:00

edwardloveall changed target branch from el-no-material-layout to main 2026年02月19日 15:15:31 +01:00

edwardloveall merged commit 1a08f89ec6 into main 2026年02月19日 15:16:16 +01:00

edwardloveall deleted branch el-shift-event-cleanup 2026年02月19日 15:16:18 +01:00

Sign in to join this conversation.

Clear labels

bug

Something is not working

contribution welcome

Contributions are very welcome, get started here

duplicate

This issue or pull request already exists

enhancement

New feature

good first issue

Interested in contributing? Get started here.

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

upstream

Related to an upstream repository, already reported there

Milestone

No milestone

Subscribe

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".