5
11
Fork
You've already forked tomato
1

Auditing EventsService::Updater #90

Merged
edwardloveall merged 1 commit from el-updater-audit into main 2026年02月12日 15:17:12 +01:00

A few updates from combing over the code that I hope will make operations more
understandable.

  • Make it clear which attributes from events vs occurrences are being updated.
  • Better understand test cases, like one that updates a recurring event to
    create a one-off event.
  • Refactor rename_task_ids
A few updates from combing over the code that I hope will make operations more understandable. - Make it clear which attributes from events vs occurrences are being updated. - Better understand test cases, like one that updates a recurring event to create a one-off event. - Refactor rename_task_ids
Auditing EventsService::Updater
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
cde6fed454
A few updates from combing over the code that I hope will make operations more
understandable.
- Make it clear which attributes from events vs occurrences are being updated.
- Better understand test cases, like one that updates a recurring event to
 create a one-off event.
- Refactor rename_task_ids
Upgrade to ruby 3.4
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
efcc9ddea5
- Bundle csv gem because it's no longer part of the std lib [1]
- Upgrade icalendar gem to remove ostruct warning [2]
- Use `it` for anonymous block parameter (standardrb requirement)
[1]: https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-0-released/#standard-library-updates
[2]: https://github.com/icalendar/icalendar/blob/main/CHANGELOG.md#2103---2024年09月21日 
edwardloveall force-pushed el-updater-audit from efcc9ddea5
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
to b9e9e5b5b8
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
2026年02月11日 17:42:08 +01:00
Compare
edwardloveall deleted branch el-updater-audit 2026年02月12日 15:17:13 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!90
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-updater-audit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?