5
11
Fork
You've already forked tomato
1

Show admins in the list of users #88

Merged
edwardloveall merged 1 commit from el-users-include-admins into main 2026年02月09日 15:59:27 +01:00

Admins often run shifts and are already managing a lot of different elements of
their job. When they run shifts they need easy access volunteer information
without having to go to many different places or accounts. This is important
because they are completing different tasks as admins and volunteers at the same
time and information can be lost or forgotten if they need to go to different
accounts. Its not getting in the way of anyone doing their job, but its
inconvenient.

So, the volunteer drop down on shifts now includes admins.

Admins often run shifts and are already managing a lot of different elements of their job. When they run shifts they need easy access volunteer information without having to go to many different places or accounts. This is important because they are completing different tasks as admins and volunteers at the same time and information can be lost or forgotten if they need to go to different accounts. Its not getting in the way of anyone doing their job, but its inconvenient. So, the volunteer drop down on shifts now includes admins.
edwardloveall force-pushed el-users-include-admins from 9b3667051f
Some checks failed
Setup Successful
Jest Failed
Static Analysis Successful
RSpec Failed
to d435b6f5d6
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
2026年02月05日 18:18:17 +01:00 Compare
edwardloveall force-pushed el-users-include-admins from d435b6f5d6
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
to 62d62fc5ab
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
2026年02月05日 18:22:08 +01:00 Compare
edwardloveall force-pushed el-users-include-admins from 62d62fc5ab
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
to ebc98a87cc
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
2026年02月05日 19:58:00 +01:00 Compare
thetizzo left a comment
Copy link

I think this is good to go but I left one small suggestion for a variable name that could be clarified. Not necessary to change though.

I think this is good to go but I left one small suggestion for a variable name that could be clarified. Not necessary to change though.
@ -46,3 +46,3 @@
.ownable
.volunteers
.users
.excluding(@users)
First-time contributor
Copy link

I would advocate for renaming the @users variable to something more descriptive since this now reads .users.excluding(@users) which seems potentially confusing. Maybe like @unavailable_users or something?

I would advocate for renaming the `@users` variable to something more descriptive since this now reads `.users.excluding(@users)` which seems potentially confusing. Maybe like `@unavailable_users` or something?
Author
Owner
Copy link

Yeah, good call. I opted for @chosen_users since it's the users already chosen for this event.

Yeah, good call. I opted for `@chosen_users` since it's the users already chosen for this event.
edwardloveall changed target branch from el-event-note-interaction to main 2026年02月09日 15:47:00 +01:00
edwardloveall force-pushed el-users-include-admins from ebc98a87cc
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
to cb72329670
All checks were successful
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Successful
2026年02月09日 15:50:56 +01:00 Compare
edwardloveall deleted branch el-users-include-admins 2026年02月09日 15:59:28 +01:00
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!88
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-users-include-admins"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?