5
11
Fork
You've already forked tomato
1

Convert event.ends_at to duration #86

Manually merged
edwardloveall merged 1 commit from el-duration into main 2026年02月05日 19:58:01 +01:00

Events used to have an ends_at attribute. In my mind, this was a misstep in
the data model. ends_at and starts_at were two independent fields that relate
to each other in the users mind, but the database had no concept of that. This
caused situations where ends_at could end before starts_at which made no
sense.

This switches to a duration instead. Users will still set an end time and not be
aware of this change. But it does reduce complexity somewhat and my hope is that
this change will reduce potential bugs.

Events used to have an `ends_at` attribute. In my mind, this was a misstep in the data model. `ends_at` and starts_at were two independent fields that relate to each other in the users mind, but the database had no concept of that. This caused situations where `ends_at` could end before starts_at which made no sense. This switches to a duration instead. Users will still set an end time and not be aware of this change. But it does reduce complexity somewhat and my hope is that this change will reduce potential bugs.
edwardloveall force-pushed el-duration from 218db1544e
Some checks failed
Setup Successful
Jest Successful
Static Analysis Successful
RSpec Failed
to 666e05a8bf
Some checks failed
Setup Successful
Jest Successful
RSpec Failed
Static Analysis Successful
2026年02月04日 19:08:57 +01:00
Compare
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rootable/tomato!86
Reference in a new issue
rootable/tomato
No description provided.
Delete branch "el-duration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?